Date: Wed, 5 Dec 2007 14:32:24 +0100 From: Max Laier <max@love2party.net> To: "Alexandre Biancalana" <biancalana@gmail.com> Cc: freebsd-pf@freebsd.org Subject: Re: carpdev ... Message-ID: <200712051432.29703.max@love2party.net> In-Reply-To: <8e10486b0712041257p6a54c50by4c340bba9c4a39b3@mail.gmail.com> References: <200710272311.09059.max@love2party.net> <8e10486b0712041257p6a54c50by4c340bba9c4a39b3@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart3219033.ROu8vbP3JY Content-Type: multipart/mixed; boundary="Boundary-01=_phqVHCzDtaTMRAv" Content-Transfer-Encoding: 7bit Content-Disposition: inline --Boundary-01=_phqVHCzDtaTMRAv Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 04 December 2007, Alexandre Biancalana wrote: > On Oct 27, 2007 7:11 PM, Max Laier <max@love2party.net> wrote: > > ... the neverending story continues :-\ > > > > I am making progress ... really, really slowly as I'm not at the top > > of my health (inflammation in my front teeth) and 7.0 got in the way, > > too. > > > > Anyways, here is something for *BETA* testing. Nobody put this in > > production (or you deserve whatever goes wrong). But if you have > > spare time and lab machines, please test and report back! Details > > welcome ;) > > Have someone tested this patch ? I'm about to put this in a > production, not intessive or high traffic, but production environment. > > Any hints ? The attached removes a debugging printf I left in by accident. There is=20 an additional printf in if_ether.c in line 684 that should be shut up in=20 the carp case, but I have the logic screwed up that should set=20 carp_match. You can shut it up for everything by setting sysctl=20 net.link.ether.inet.log_arp_wrong_iface=3D0, but that's only bandaid. Other than that I'm not aware of any problems, panic or the like. Please=20 let me know how things go for you! Oh ... IPv6 is not working with this patchset! The attachment is relative= =20 to the patched source! =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --Boundary-01=_phqVHCzDtaTMRAv Content-Type: text/x-diff; charset="iso-8859-1"; name="carp_nodebug.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="carp_nodebug.diff" diff --git a/sys/netinet/ip_carp.c b/sys/netinet/ip_carp.c index 7bb9404..aea3518 100644 =2D-- a/sys/netinet/ip_carp.c +++ b/sys/netinet/ip_carp.c @@ -1213,17 +1213,9 @@ carp_iamatch(void *v, struct in_ifaddr *ia, struct carp_softc *vh; int index, count =3D 0; struct ifaddr *ifa; =2D char iastr[INET_ADDRSTRLEN]; =2D char isstr[INET_ADDRSTRLEN]; =2D =20 CARP_LOCK(cif); =20 =2D inet_ntoa_r(ia->ia_addr.sin_addr, iastr); =2D inet_ntoa_r(*isaddr, isstr); =2D printf("carp_iamatch(%s, %s, %s, ...)\n", cif->vhif_ifp->if_xname, =2D iastr, isstr); =2D if (carp_opts[CARPCTL_ARPBALANCE]) { /* * XXX proof of concept implementation. @@ -1275,11 +1267,8 @@ carp_iamatch(void *v, struct in_ifaddr *ia, ia->ia_ifp =3D=3D SC2IFP(vh) && vh->sc_state =3D=3D MASTER) { *enaddr =3D IF_LLADDR(vh->sc_ifp); =2D printf("found: %s\n", vh->sc_ifp->if_xname); CARP_UNLOCK(cif); return (1); =2D } else { =2D printf("not: %s\n", vh->sc_ifp->if_xname); } } } --Boundary-01=_phqVHCzDtaTMRAv-- --nextPart3219033.ROu8vbP3JY Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQBHVqhtXyyEoT62BG0RAkPwAJ9hIbg47qv1JVOizndbsBeiX4xA0ACfTdH0 JISD5Jv2qKgHP2awezLtdWc= =axB9 -----END PGP SIGNATURE----- --nextPart3219033.ROu8vbP3JY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712051432.29703.max>