Date: Wed, 13 Jan 1999 08:37:34 +1100 (EST) From: John Birrell <jb@cimlogic.com.au> To: archie@whistle.com (Archie Cobbs) Cc: mike@smith.net.au, eivind@FreeBSD.ORG, luigi@labinfo.iet.unipi.it, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet ip_input.c Message-ID: <199901122137.IAA08522@cimlogic.com.au> In-Reply-To: <199901122124.NAA07208@bubba.whistle.com> from Archie Cobbs at "Jan 12, 1999 1:24:53 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Archie Cobbs wrote: > Mike Smith writes: > > > Unless good counter-arguments spring forward, -Werror is going in > > > shortly, so tolerating the warnings is not an option. > > > > -Werror is anal fluff. I applaud it being the default for general > > usage, but -Werror made working on NetBSD *extremely* difficult. > > Stamping out warnings is desirable, but sometimes the crud in the code > > required to do it is worse than the warning. > > This is not a counter-argument, only a report from my personal > experience. > > To me the gcc warnings are *essential* to producing bug-free code > in a timely manner. Therefore, getting to -Werror is a good goal. > > While there are weird corner cases where a warning may be unavoidable, > gcc provides mechanisms to deal with these (like our __dead and __unused). > > So IMHO it's pretty vanishingly rare that -Werror is impossible to achieve. If you are working on a "problem child" in the tree and in doing so you choose to compile without optimisation, your build is likely to fail due to -Werror barfing on static inline definitions in the headers that aren't used. This is *really* annoying. I removed -Werror from a couple of places in the tree when porting stuff to alpha because of this. If people want to _add_ -Werror in their local /etc/make.conf, by all means do so, but please don't make it required. -- John Birrell - jb@cimlogic.com.au; jb@freebsd.org http://www.cimlogic.com.au/ CIMlogic Pty Ltd, GPO Box 117A, Melbourne Vic 3001, Australia +61 418 353 137 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901122137.IAA08522>