Date: Mon, 1 Apr 2002 22:11:39 -0500 (EST) From: Mikhail Teterin <mi@aldan.algebra.com> To: jkh@winston.freebsd.org Cc: obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall install.c installUpgrade.c media.c package.c Message-ID: <200204020311.g323BdFX074921@aldan.algebra.com> In-Reply-To: <23637.1017716120@winston.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1 Apr, Jordan Hubbard wrote: >> On 1 Apr, Jordan Hubbard wrote: >> >> Why can't the packages be extracted "in place" by the sysinstall? [...] >> I just wonder how, then, the ``@option extract-in-place'' is implemented >> and why is it not used by default... > > You wonder only because you haven't reviewed the code exection path > for any actual package addition operations. :-) That's right :-) > @option extract-in-place is not for anything produced by > pkg_create(1). It's for tarballs masquerading as packages that don't > depend on the package support routines for anything other than > extraction. As far as I know, no one has ever used this feature and > it's basically one of those use-at-your-own-risk experimental sort of > features. I imagine, a LOT of ports should have this added into their pkg-plist files. But then I only read about this feature today... >> I'm not so certain of that, as a matter of fact. My last attempt to >> enhance pkg-code is still waiting (after two months) in the bin/34628: >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/34628 > > Probably because not too many people understand that code and your > proposed enhancement is a little obscure in any case. The only thing > it really visibly adds is an extra warning message. You're also > responsible for checking the result of sscanf() in your code since not > all @comment lines are md5 data - they can be anything. I don't think that's true. If sscanf fails, it will leave chsum zeroed out and the code will know later on, there is no pre-recorded md5. I'm not THAT lame :-) Can we discuss this privately with the aim of you committing it? Sobomax seems too busy... > And yeah, in retrospect I'm sorry I didn't add an @md5 directive. -mi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200204020311.g323BdFX074921>