Date: Tue, 20 Nov 2018 11:52:06 -0800 From: Mark Millard <marklmi@yahoo.com> To: mjg@FreeBSD.org, svn-src-head@freebsd.org Subject: Re: svn commit: r340676 - in head/sys: kern sys Message-ID: <C9E360E2-C68E-4FC3-A149-7E591E0E5423@yahoo.com>
next in thread | raw e-mail | index | archive | help
Mateusz Guzik mjg at FreeBSD.org wrote on Tue Nov 20 14:58:42 UTC 2018 : > +#if defined(__mips__) || defined(__powerpc__) > +#define UNR64_LOCKED > +#endif But on powerpc64 ( system clang from head -r339076 ): # clang -dM -E -x c /dev/null | grep -i __power #define __POWERPC__ 1 #define __powerpc64__ 1 #define __powerpc__ 1 and (I only have the one gcc* vintage around): # gcc8 -dM -E -x c /dev/null | grep -i __power #define __powerpc64__ 1 #define __powerpc__ 1 so the following are used on powerpc64: +#ifdef UNR64_LOCKED +uint64_t alloc_unr64(struct unrhdr64 *); +#else . . . and: +#ifdef UNR64_LOCKED +uint64_t +alloc_unr64(struct unrhdr64 *unr64) +{ + uint64_t item; + + mtx_lock(&unitmtx); + item =3D unr64->counter++; + mtx_unlock(&unitmtx); + return (item); +} +#endif Was that the intent for powerpc64? Notes about the powerpc64 context used: # uname -apKU FreeBSD FBSDG5L 12.0-ALPHA8 FreeBSD 12.0-ALPHA8 #4 r339076M: Mon Oct 15 = 13:19:35 PDT 2018 = markmi@FBSDG5L:/usr/obj/powerpc64vtsc_xtoolchain-gcc/powerpc.powerpc64/usr= /src/powerpc.powerpc64/sys/GENERIC64vtsc-NODBG powerpc powerpc64 = 1200084 1200084 buildworld buildkernel was via devel/powerpc64-xtoolchain-gcc . =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C9E360E2-C68E-4FC3-A149-7E591E0E5423>