Date: Mon, 23 Sep 2002 23:45:23 +1000 From: Tim Robbins <tjr@FreeBSD.org> To: Mike Barcroft <mike@FreeBSD.org> Cc: standards@FreeBSD.org, Josef Karthauser <joe@tao.org.uk> Subject: Re: select.diff for review Message-ID: <20020923234523.A27512@dilbert.robbins.dropbear.id.au> In-Reply-To: <20020922235943.G91924@espresso.q9media.com>; from mike@FreeBSD.org on Sun, Sep 22, 2002 at 11:59:43PM -0400 References: <20020922235943.G91924@espresso.q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 22, 2002 at 11:59:43PM -0400, Mike Barcroft wrote: > Attached is a patch which makes <sys/select.h> much more conformant by > bringing over components from <sys/types.h>. Comments appreciated. [...] > Index: include/unistd.h [...] > +#if __BSD_VISIBLE > +#ifndef _SELECT_DECLARED > +#define _SELECT_DECLARED > int select(int, fd_set *, fd_set *, fd_set *, struct timeval *); > +#endif > +#endif I think it's probably better if you don't test whether select() has been declared, and simply declare it anyway. If the two prototypes get out of sync with each other, the compiler will warn, otherwise it's harmless. Tim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-standards" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020923234523.A27512>