Date: Mon, 29 Jan 2007 14:45:48 -0800 From: Nate Lawson <nate@root.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/geom/eli g_eli.c Message-ID: <45BE791C.1080501@root.org> In-Reply-To: <20070129184522.GD87767@garage.freebsd.pl> References: <20070128202917.5B67916A5A6@hub.freebsd.org> <45BD82D2.20301@root.org> <20070129175222.GA87767@garage.freebsd.pl> <45BE37DC.6080509@root.org> <20070129184522.GD87767@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
Pawel Jakub Dawidek wrote: > On Mon, Jan 29, 2007 at 10:07:24AM -0800, Nate Lawson wrote: >> Pawel Jakub Dawidek wrote: >>> Hmm, I thought that cold is zeroed before smp_started is set? >> I don't think that's guaranteed. Besides, there's an easier way to fix your problem. Instead of calling kthread_create() from your geom create routine directly, queue a >> stub request on the thread taskqueue to call kthread_create(). >> >> For example, see sys/dev/acpica/acpi_acad.c. We call this from attach() and then the system thread only runs and then calls acpi_acad_init() once all CPUs are >> initialized. See sys/sys/taskqueue.h for how to add a task to the system thread taskqueue: >> >> taskqueue_enqueue(taskqueue_thread, &task); > > If we want to fix it better, I think GEOM should start (tasting at > least) after all CPUs are online. > Fine, take my suggestion and bump it up a level. Have GEOM queue an event on a taskqueue that will be run once all CPUs are available to begin tasting. And Robert's suggestion sounds good in the long run. -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45BE791C.1080501>