Date: Sun, 17 Nov 1996 20:20:29 -0800 (PST) From: torii@tcd.hitachi.co.jp To: freebsd-gnats-submit@freebsd.org Subject: bin/2046: vjcomp problem in iij-ppp Message-ID: <199611180420.UAA08013@freefall.freebsd.org> Resent-Message-ID: <199611180430.UAA08438@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 2046
>Category: bin
>Synopsis: vjcomp problem in iij-ppp
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Nov 17 20:30:11 PST 1996
>Last-Modified:
>Originator: Nobuyoshi Torii
>Organization:
Telecommunications Division, Hitachi, Ltd., Japan
>Release: 2.1.0-RELEASE
>Environment:
FreeBSD pc07098.tcd.hitachi.co.jp 2.1.0-RELEASE FreeBSD 2.1.0-RELEASE #0: Wed Apr 10 10:16:09 JST 1996
root@pc07098.tcd.hitachi.co.jp:/usr/src/sys/compile/FLORA i386
>Description:
Ping or UDP packets are sometimes dropped in use of iij-ppp.
Iij-ppp attempts to use VJ compress even if the packet is not TCP.
PPP packet's protocol field of UDP or ICMP is sometimes filled by
COMPRESSED_TCP or UNCOMPRESSED_TCP.
Incidentially, iij-ppp log buffer is too small to take async or
hdlc logging.
>How-To-Repeat:
Use ping or tftp put from iij-ppp side.
Ping packet loss ratio is about 6 or 7 percent.
Tftp put will be faild by timeout.
>Fix:
*** ppp-2.1.0/vjcomp.c Fri Nov 15 20:41:44 1996
--- ppp.patch/vjcomp.c Fri Nov 15 20:40:55 1996
***************
*** 51,57 ****
#ifdef DEBUG
logprintf("SendPppFrame: proto = %x\n", IpcpInfo.his_compproto);
#endif
! if (cproto== PROTO_VJCOMP) {
type = sl_compress_tcp(bp, (struct ip *)MBUF_CTOP(bp), &cslc, IpcpInfo.his_compproto & 0xff);
#ifdef DEBUG
--- 51,58 ----
#ifdef DEBUG
logprintf("SendPppFrame: proto = %x\n", IpcpInfo.his_compproto);
#endif
! if (((struct ip *)MBUF_CTOP(bp))->ip_p == IPPROTO_TCP
! && cproto== PROTO_VJCOMP) {
type = sl_compress_tcp(bp, (struct ip *)MBUF_CTOP(bp), &cslc, IpcpInfo.his_compproto & 0xff);
#ifdef DEBUG
*** ppp-2.1.0/log.c Fri Nov 15 20:41:49 1996
--- ppp.patch/log.c Fri Nov 15 20:40:55 1996
***************
*** 41,47 ****
#ifdef USELOGFILE
static FILE *logfile;
#endif
! static char logbuff[2000];
static char *logptr;
static struct mbuf *logtop;
static struct mbuf *lognext;
--- 41,47 ----
#ifdef USELOGFILE
static FILE *logfile;
#endif
! static char logbuff[MAX_MRU*3+(MAX_MRU/16+1)*22+80];
static char *logptr;
static struct mbuf *logtop;
static struct mbuf *lognext;
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199611180420.UAA08013>