Date: Sat, 27 Sep 2014 15:51:46 -0500 From: Scot Hetzel <swhetzel@gmail.com> To: Dan Langille <dan@langille.org> Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: is bsd.database.mk out of sync with Uses/pgsql.mk? Message-ID: <CACdU%2Bf8pkcrc-gbMhzvLG=21x%2BgCQjSf4zGXLHvHs%2BXwK9X7Zw@mail.gmail.com> In-Reply-To: <7E30A7E8-D312-4861-BB25-E2AE6B3F405E@langille.org> References: <7E30A7E8-D312-4861-BB25-E2AE6B3F405E@langille.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 27, 2014 at 2:52 PM, Dan Langille <dan@langille.org> wrote: > Today I encountered these build messages with poudriere: > > Invalid PGSQL default version 92; valid versions are 8.4 9.0 9.1 9.2 9.3 9.4 > > These messages originate in Mk/Uses/pgsql.mk > > But Mk/bsd.database.mk claims a different format is correct: > > # DEFAULT_PGSQL_VER > # - PostgreSQL default version, currently 90. > > > Do you agree that the comments in Mk/bsd.database.mk need to updated? > According to Mk/Uses/pgsql.mk, DEFAULT_PGSQL_VER and WITH_PGSQL_VER are obsolete, and you should be using DEFAULT_VERSIONS=pgsql=9.2 instead. They are kept for backward compatibility, but require you to use the new version format (i.e 9.2). The USE_PGSQL code in Mk/bsd.database.mk is still using the old version format (92). I would consider that USE_PGSQL is obsolete, and ports that are still using USE_PGSQL should be updated to USES+= pgsql. -- DISCLAIMER: No electrons were maimed while sending this message. Only slightly bruised.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACdU%2Bf8pkcrc-gbMhzvLG=21x%2BgCQjSf4zGXLHvHs%2BXwK9X7Zw>