Date: Mon, 29 Jul 2013 13:21:28 -0700 From: Sean Bruno <sean_bruno@yahoo.com> To: sbruno@freebsd.org Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r253708 - head/sys/dev/ipmi Message-ID: <1375129288.1479.36.camel@localhost> In-Reply-To: <1375127952.1479.32.camel@localhost> References: <201307271632.r6RGWYF8046749@svn.freebsd.org> <201307291054.55820.jhb@freebsd.org> <1375127952.1479.32.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-VDU4fb1zgiUJhY+rY5fu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Mon, 2013-07-29 at 12:59 -0700, Sean Bruno wrote: > On Mon, 2013-07-29 at 10:54 -0400, John Baldwin wrote: > > On Saturday, July 27, 2013 12:32:34 pm Sean Bruno wrote: > > > Author: sbruno > > > Date: Sat Jul 27 16:32:34 2013 > > > New Revision: 253708 > > > URL: http://svnweb.freebsd.org/changeset/base/253708 > > >=20 > > > Log: > > > At some point after stable/7 the ACPI and ISA interfaces to the IPM= I controller > > > no longer have the parent in the device tree. This causes the iden= tify > > > function in ipmi_isa.c to attempt to probe and poke at the ISA IPMI= interface > >=20 > > They never had a common parent, even in 6.x and 7.x. > >=20 > The identify function in isa_ipmi.c shows that there is already an > ipmi(4) device attached (ACPI) version and aborts on 7.x. in 9.x and > higher (not testing on 8.x) the identify function does not see an > attached ipmi interface and attempts to create /dev/ipmi1 >=20 > Am I just confused on the bus relationship here? >=20 > We've gone over this a couple of times in different emails on different > lists. I've just never sat down and walked through the code. If you > see a better way to keep ipmi(4) from erroneously attaching to the ISA > interface, let me know. Or ... ya know, I could just be 100% wrong? stable/7 attaches to an /dev/ipmi1 as well on these Dell R410 units. *sigh* http://people.freebsd.org/~sbruno/ipmi_sean_is_wrong.txt so, the modification I made does resolve the "ipmi1" thing alltogether and is correct (AFAIK), but should be applied to all revisions, not just 9/head. Or, am I wrong again? :-) Sean --=-VDU4fb1zgiUJhY+rY5fu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (FreeBSD) iQEcBAABAgAGBQJR9s7IAAoJEBkJRdwI6BaHWbAH/Ra9Myclh3FUQde7XrcZcb16 yHtKbi8lOTKNriSxcS68K7XVBKqieVwGVXbwlhOuGbwyXbZd+Fu26P79D8Hutzio 33MucMX8PFTOKMOqr8dO3Ii/howf+gtopVXRJA2BiB4fFIA5f3Pnep7M+aUJPFSZ 8DQp071X3TmOezRLqRE404SD2dFf3tuQaWFNo7oEPKAdinrHa0HiXtXPz72sB7Dp 0C+l32Gng++kcHPZKbI69g9Rp7Fg2nbvFA6pBYDpFnwMulO9NvOUbRWsdkToxj1s R3seGx+lDiFvQeKzlG7SyyEe77XbC04Umahci9PF15hhVKwYMU6tOgsFtgbd2pw= =ldSc -----END PGP SIGNATURE----- --=-VDU4fb1zgiUJhY+rY5fu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1375129288.1479.36.camel>