Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Jan 2001 15:42:37 +1100
From:      Peter Jeremy <peter.jeremy@alcatel.com.au>
To:        Robert Watson <rwatson@FreeBSD.ORG>
Cc:        cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/ufs/ufs ufs_extattr.c
Message-ID:  <20010111154237.A91242@gsmx07.alcatel.com.au>
In-Reply-To: <200101072107.f07L7Ps13036@freefall.freebsd.org>; from rwatson@FreeBSD.ORG on Sun, Jan 07, 2001 at 01:07:25PM -0800
References:  <200101072107.f07L7Ps13036@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2001-Jan-07 13:07:25 -0800, Robert Watson <rwatson@FreeBSD.ORG> wrote:
>rwatson     2001/01/07 13:07:25 PST
>
>  Modified files:
>    sys/ufs/ufs          ufs_extattr.c 
>  Log:
>  o Remove unnecessary sanity check involving requested offset of extended
>    attribute read--the offset is required to be 0 by an earlier check,
>    meaning that it will always be within the scope of the attribute data.
>    This change should have no impact on executed code paths other than
>    removing the unnecessary check: please report if any new failures
>    start to occur as a result.

Couldn't this have been changed to a KASSERT?  This would provide a
fairly clear indication that something has gone wrong.

Peter


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010111154237.A91242>