Date: Tue, 28 Oct 2008 14:14:57 +0000 (UTC) From: Oleg Bulyzhin <oleg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r184414 - in head: . sys/netinet Message-ID: <200810281414.m9SEEvZE096007@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: oleg Date: Tue Oct 28 14:14:57 2008 New Revision: 184414 URL: http://svn.freebsd.org/changeset/base/184414 Log: Type of q_time (start of queue idle time) has changed: uint32_t -> uint64_t. This should fix q_time overflow, which happens after 2^32/(86400*hz) days of uptime (~50days for hz = 1000). q_time overflow cause following: - traffic shaping may not work in 'fast' mode (not enabled by default). - incorrect average queue length calculation in RED/GRED algorithm. NB: due to ABI change this change is not applicable to stable. PR: kern/128401 Modified: head/UPDATING head/sys/netinet/ip_dummynet.h Modified: head/UPDATING ============================================================================== --- head/UPDATING Tue Oct 28 13:44:11 2008 (r184413) +++ head/UPDATING Tue Oct 28 14:14:57 2008 (r184414) @@ -22,6 +22,9 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 8. to maximize performance. (To disable malloc debugging, run ln -s aj /etc/malloc.conf.) +20081028: + dummynet(4) ABI has changed. ipfw(8) needs to be recompiled. + 20081009: The uhci, ohci, ehci and slhci USB Host controller drivers have been put into separate modules. If you load the usb module Modified: head/sys/netinet/ip_dummynet.h ============================================================================== --- head/sys/netinet/ip_dummynet.h Tue Oct 28 13:44:11 2008 (r184413) +++ head/sys/netinet/ip_dummynet.h Tue Oct 28 14:14:57 2008 (r184414) @@ -216,7 +216,7 @@ struct dn_flow_queue { int avg ; /* average queue length est. (scaled) */ int count ; /* arrivals since last RED drop */ int random ; /* random value (scaled) */ - u_int32_t q_time ; /* start of queue idle time */ + dn_key q_time; /* start of queue idle time */ /* WF2Q+ support */ struct dn_flow_set *fs ; /* parent flow set */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810281414.m9SEEvZE096007>