Date: Fri, 24 Dec 2010 22:00:08 +0200 From: Andriy Gapon <avg@freebsd.org> To: Artem Belevich <fbsdlist@src.cx> Cc: freebsd-hackers@freebsd.org, FreeBSD-Current <freebsd-current@freebsd.org> Subject: Re: [dtrace] syscall provider naming convention. Message-ID: <4D14FBC8.9060304@freebsd.org> In-Reply-To: <AANLkTinJrBQSYoOt_d4eMhWpVhU7tJkvafWKdu71j55A@mail.gmail.com> References: <AANLkTi=z1_KWKmhqFjNYHZfgAyPgsUVvgJ0P29KOPpnZ@mail.gmail.com> <20101211215341.0000097c@unknown> <AANLkTi=ehLNs8aeYfGUattetm7oMj8HhEB1Vnep9uAZk@mail.gmail.com> <20101213103535.00005f3d@unknown> <4D061E00.7050606@freebsd.org> <AANLkTinJrCRscZwYCAwXERTs6X=-yaz6go3FTSmc6Zdx@mail.gmail.com> <4D0F3AD6.9080002@freebsd.org> <AANLkTikkpbJV0v1=mBc%2BnFBh_diyAjUjaN8BUKwEZZhp@mail.gmail.com> <AANLkTinRGx-r-MpusXecTpjKbwAUHktM6qPxRxz1B8DX@mail.gmail.com> <4D1077AB.4010707@freebsd.org> <AANLkTinJrBQSYoOt_d4eMhWpVhU7tJkvafWKdu71j55A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
on 24/12/2010 04:02 Artem Belevich said the following: >> I have one comment though. I am not sure about renaming syscall.ko to >> syscall_freebsd.ko. > > You mean systrace_freebsd.ko. Yes, thanks. > I've renamed it for consistency with other systrace provider variants. > I can change it back. I think that I would prefer this. If only for POLA reasons. >> Perhaps we could keep the old name? Or add a new module >> under that name that would load native syscall module and all emulation syscall >> modules (if any)? > > I'm not sure that creating an umbrella 'systrace' module is worth it. > "kldload /boot/kernel/systrace*" should do that just fine. The reason > dtrace exists is that there are number of modules with dtrace > providers that are not easily distinguishable by their name. I agree. I am going on vacation and I don't want to risk, so it looks like I will be able to commit your patch after the holidays. Unless someone else beats me to it. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D14FBC8.9060304>