Date: Wed, 20 Feb 2019 16:34:57 -0700 From: Warner Losh <imp@bsdimp.com> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Mark Johnston <markj@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org, patrick.mooney@joyent.com Subject: Re: svn commit: r344364 - vendor/illumos/dist/lib/libdtrace/common Message-ID: <CANCZdfqSgOf_b-3Hq2BcxzekL%2BOqKV77zc3uWMM-hSoM3jOwTg@mail.gmail.com> In-Reply-To: <201902201719.x1KHJNwL016175@pdx.rh.CN85.dnsmgr.net> References: <201902201705.x1KH5E9V039924@repo.freebsd.org> <201902201719.x1KHJNwL016175@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 20, 2019 at 10:19 AM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: markj > > Date: Wed Feb 20 17:05:13 2019 > > New Revision: 344364 > > URL: https://svnweb.freebsd.org/changeset/base/344364 > > > > Log: > > 9058 postmortem DTrace frequently broken under vmware > > > > illumos/illumos-gate@793bd7e3617ae7d3d24e8c6b7d6befe35f07ec1f > > > > Reviewed by: Tim Kordas <tim.kordas@joyent.com> > > Reviewed by: Patrick Mooney <patrick.mooney@joyent.com> > > Reviewed by: Yuri Pankov <yuripv@yuripv.net> > > Reviewed by: Matthew Ahrens <mahrens@delphix.com> > > Approved by: Matthew Ahrens <mahrens@delphix.com> > > Author: Sam Gwydir <sam.gwydir@joyent.com> > > > > Modified: > > vendor/illumos/dist/lib/libdtrace/common/dt_consume.c > > > > Modified: vendor/illumos/dist/lib/libdtrace/common/dt_consume.c > > > ============================================================================== > > --- vendor/illumos/dist/lib/libdtrace/common/dt_consume.c Wed Feb 20 > 14:12:25 2019 (r344363) > > +++ vendor/illumos/dist/lib/libdtrace/common/dt_consume.c Wed Feb 20 > 17:05:13 2019 (r344364) > > @@ -24,7 +24,7 @@ > > */ > > > > /* > > - * Copyright (c) 2013, Joyent, Inc. All rights reserved. > > + * Copyright (c) 2017, Joyent, Inc. All rights reserved. > > This change to this copyright is very questionable. > One should always retain the first date of publication > in a copyright statement. > > I do understand your just importing a change from illumous, > but I want it on public record that I have raised issue > with this change to a copyright, and this has nothing to > do with you personally, or you wanting to bring this code > over. > Joyent is following the old Sun practice of listing the last date only. I've had my company's lawyers tell me in the past this is acceptable. In my research, as layperson, I've found advice going all three ways: list every year, or else; earliest-latest year range; only the latest year. I once asked an IP lawyer that handled a friend's trademark case for clue.com. He said that there is a diversity of legal opinion in the legal community, and that in some specific cases one might be favored over the other. Most of the time, in his opinion, the differences don't matter to open source. He hastened to add he couldn't give any blanket statements on the topic and for proper legal advice he'd need to know more about the specific use. And then we had another beer and chatted about other things. I never followed up. In the years since this, I've seen all three styles used. Warner > * Copyright (c) 2012 by Delphix. All rights reserved. > > */ > > > > @@ -3010,9 +3010,6 @@ dtrace_consume(dtrace_hdl_t *dtp, FILE *fp, > > break; > > > > timestamp = dt_buf_oldest(buf, dtp); > > - assert(timestamp >= dtp->dt_last_timestamp); > > - dtp->dt_last_timestamp = timestamp; > > - > > if (timestamp == buf->dtbd_timestamp) { > > /* > > * We've reached the end of the time > covered > > @@ -3026,6 +3023,8 @@ dtrace_consume(dtrace_hdl_t *dtp, FILE *fp, > > break; > > continue; > > } > > + assert(timestamp >= dtp->dt_last_timestamp); > > + dtp->dt_last_timestamp = timestamp; > > > > if ((rval = dt_consume_cpu(dtp, fp, > > buf->dtbd_cpu, buf, B_TRUE, pf, rf, arg)) != 0) > > > > > > -- > Rod Grimes > rgrimes@freebsd.org > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqSgOf_b-3Hq2BcxzekL%2BOqKV77zc3uWMM-hSoM3jOwTg>