Date: Tue, 5 May 2009 10:18:30 -0400 From: Ben Kelly <ben@wanderview.com> To: current@freebsd.org Subject: [patch] corrupt memstat_kvm_malloc(3) output and dtrace Message-ID: <9A637B27-7C89-49BA-8385-A5B2D5D54BB3@wanderview.com>
next in thread | raw e-mail | index | archive | help
Hi all, While debugging a problem recently with Alexander Leidinger we noticed that crashinfo(8) was producing corrupt vmstat -m output. After doing some digging it appears that memstat_kvm_malloc(3) might have been broken by this commit: http://svn.freebsd.org/viewvc/base?view=revision&revision=179222 The problem is that memstat_kvm_malloc(3) assumes that malloc_type_internal starts with an array of malloc_types_stats structures. This assumption is no longer true, though, as mti_probes was inserted at the start of the structure. It appears that this (untested) patch might fix the problem: http://www.wanderview.com/svn/public/misc/zfs/vmstat_kvm_malloc.diff I'm not very familiar with dtrace, though. Does anyone know if this would cause problems? Thanks. - Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9A637B27-7C89-49BA-8385-A5B2D5D54BB3>