Date: Mon, 25 Dec 2017 20:50:38 +0100 From: Tijl Coosemans <tijl@FreeBSD.org> To: Yuri Victorovich <yuri@FreeBSD.org>, adamw@FreeBSD.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r457249 - in head/math: . SCIP Message-ID: <20171225205038.29a0c816@kalimero.tijl.coosemans.org> In-Reply-To: <201712251903.vBPJ3UpP037293@repo.freebsd.org> References: <201712251903.vBPJ3UpP037293@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 25 Dec 2017 19:03:30 +0000 (UTC) Yuri Victorovich <yuri@FreeBSD.org> wrote: > Author: yuri > Date: Mon Dec 25 19:03:30 2017 > New Revision: 457249 > URL: https://svnweb.freebsd.org/changeset/ports/457249 > > Log: > New port: math/SCIP: Solver for mixed integer, mixed integer nonlinear programming > > Submitted by: myself > Approved by: adamw (mentor) > Differential Revision: https://reviews.freebsd.org/D13614 > > Added: > head/math/SCIP/ > head/math/SCIP/Makefile (contents, props changed) > head/math/SCIP/distinfo (contents, props changed) > head/math/SCIP/pkg-descr (contents, props changed) > head/math/SCIP/pkg-plist (contents, props changed) > Modified: > head/math/Makefile > > Modified: head/math/Makefile > ============================================================================== > --- head/math/Makefile Mon Dec 25 19:01:08 2017 (r457248) > +++ head/math/Makefile Mon Dec 25 19:03:30 2017 (r457249) > @@ -91,6 +91,7 @@ > SUBDIR += R-cran-units > SUBDIR += R-cran-xts > SUBDIR += R-cran-zoo > + SUBDIR += SCIP > SUBDIR += SoPlex > SUBDIR += aamath > SUBDIR += abacus > > Added: head/math/SCIP/Makefile > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/math/SCIP/Makefile Mon Dec 25 19:03:30 2017 (r457249) > @@ -0,0 +1,27 @@ > +# Created by: Yuri Victorovich <yuri@FreeBSD.org> > +# $FreeBSD$ > + > +PORTNAME= SCIP > +DISTVERSION= 5.0.0 > +CATEGORIES= math science > +MASTER_SITES= http://scip.zib.de/download/release/ > +DISTNAME= ${PORTNAME:tl}-${DISTVERSION} Surely, if upstream names their packages using lower case... > Added: head/math/SCIP/pkg-plist > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/math/SCIP/pkg-plist Mon Dec 25 19:03:30 2017 (r457249) > @@ -0,0 +1,436 @@ > +bin/scip ...names their binaries,... > +include/scip/bandit.h > +include/scip/bandit_epsgreedy.h > +include/scip/bandit_exp3.h > +include/scip/bandit_ucb.h ...headers and... > +lib/cmake/scip/scip-config.cmake > +lib/cmake/scip/scip-targets-%%CMAKE_BUILD_TYPE%%.cmake > +lib/cmake/scip/scip-targets.cmake > +lib/libscip.so > +lib/libscip.so.%%SHL2%% > +lib/libscip.so.%%SHL4%% ...libraries all lower case, our port and package should also be lower case. I'm not as extreme as danfe on the use of upper case, but I do think it should be kept to a minimum in the ports tree. And this is not an aesthetic thing. Your adding of upper case everywhere is breaking tradition in the ports tree and causing inconsistency.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171225205038.29a0c816>