Date: Wed, 24 Jul 2013 15:29:34 -0400 From: John Baldwin <jhb@freebsd.org> To: "David E. O'Brien" <obrien@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r253618 - head/sys/dev/usb/gadget Message-ID: <201307241529.35175.jhb@freebsd.org> In-Reply-To: <201307241832.r6OIWFGc074918@svn.freebsd.org> References: <201307241832.r6OIWFGc074918@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, July 24, 2013 2:32:15 pm David E. O'Brien wrote: > Author: obrien > Date: Wed Jul 24 18:32:15 2013 > New Revision: 253618 > URL: http://svnweb.freebsd.org/changeset/base/253618 > > Log: > per style(9): > Kernel include files (i.e. sys/*.h) come first; normally, include > <sys/types.h> OR <sys/param.h>, but not both. <sys/types.h> includes > <sys/cdefs.h>, and it is okay to depend on that. This is not fully correct. The consistent style throughout the tree when using _FBSDID() is: #include <sys/cdefs.h> __FBSDID() #include <sys/param.h> ... Please fix these to match that. It might not be a bad idea to document the __FBSDID() practice in style.9 while you are at it. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307241529.35175.jhb>