Date: Mon, 26 Sep 2016 15:25:46 -0600 From: Warner Losh <imp@bsdimp.com> To: Ruslan Bukin <br@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r306347 - head/lib/libc/tests Message-ID: <CANCZdfqFXit76vnvbw=fube3s7M4BuvG7U4iGD4AUmLAwDbLAA@mail.gmail.com> In-Reply-To: <201609261538.u8QFc2Av023865@repo.freebsd.org> References: <201609261538.u8QFc2Av023865@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Shouldn't we have MK_SSP == no on mips instead? That's how it's supposed to work. If it isn't, perhaps we should set it like that. Warner On Mon, Sep 26, 2016 at 9:38 AM, Ruslan Bukin <br@freebsd.org> wrote: > Author: br > Date: Mon Sep 26 15:38:02 2016 > New Revision: 306347 > URL: https://svnweb.freebsd.org/changeset/base/306347 > > Log: > Don't build SSP tests on MIPS as we dont have stack-protector > supported on this platform. > > Discussed with: brooks > Sponsored by: DARPA, AFRL > Sponsored by: HEIF5 > > Modified: > head/lib/libc/tests/Makefile > > Modified: head/lib/libc/tests/Makefile > ============================================================================== > --- head/lib/libc/tests/Makefile Mon Sep 26 15:30:30 2016 (r306346) > +++ head/lib/libc/tests/Makefile Mon Sep 26 15:38:02 2016 (r306347) > @@ -30,7 +30,8 @@ SUBDIR_DEPEND_tls= tls_dso > TESTS_SUBDIRS+= locale > .endif > > -.if ${MK_SSP} != "no" > +.if ${MK_SSP} != "no" && \ > + ${MACHINE_CPUARCH} != "mips" > TESTS_SUBDIRS+= ssp > .endif > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqFXit76vnvbw=fube3s7M4BuvG7U4iGD4AUmLAwDbLAA>