Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Oct 2008 10:22:41 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Peter Wemm <peter@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r184385 - head/sys/kern
Message-ID:  <200810281022.41296.jhb@freebsd.org>
In-Reply-To: <200810280326.m9S3QPit080877@svn.freebsd.org>
References:  <200810280326.m9S3QPit080877@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 27 October 2008 11:26:25 pm Peter Wemm wrote:
> Author: peter
> Date: Tue Oct 28 03:26:25 2008
> New Revision: 184385
> URL: http://svn.freebsd.org/changeset/base/184385
> 
> Log:
>   After a machine has been up for a bit more than 20 days with HZ=1000,
>   "ticks" goes negative.  This breaks the signed comparison in softclock.
>   This causes sleep() to never wake up, tcp to stop, etc etc.  This is
>   bad(TM).  Use the SEQ_LT() method from tcp's sequence number comparisons.
> 
> Modified:
>   head/sys/kern/kern_timeout.c

I wonder why this used < rather than the != that older branches used.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810281022.41296.jhb>