Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Jun 2010 00:41:21 +0000 (UTC)
From:      Alan Cox <alc@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r209226 - head/sys/fs/tmpfs
Message-ID:  <201006160041.o5G0fLvZ041271@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: alc
Date: Wed Jun 16 00:41:21 2010
New Revision: 209226
URL: http://svn.freebsd.org/changeset/base/209226

Log:
  Eliminate unnecessary page queues locking.

Modified:
  head/sys/fs/tmpfs/tmpfs_vnops.c

Modified: head/sys/fs/tmpfs/tmpfs_vnops.c
==============================================================================
--- head/sys/fs/tmpfs/tmpfs_vnops.c	Tue Jun 15 23:55:42 2010	(r209225)
+++ head/sys/fs/tmpfs/tmpfs_vnops.c	Wed Jun 16 00:41:21 2010	(r209226)
@@ -653,9 +653,7 @@ lookupvpg:
 			goto lookupvpg;
 		}
 		vm_page_busy(vpg);
-		vm_page_lock_queues();
 		vm_page_undirty(vpg);
-		vm_page_unlock_queues();
 		VM_OBJECT_UNLOCK(vobj);
 		error = uiomove_fromphys(&vpg, offset, tlen, uio);
 	} else {
@@ -690,15 +688,13 @@ nocache:
 out:
 	if (vobj != NULL)
 		VM_OBJECT_LOCK(vobj);
-	vm_page_lock(tpg);
-	vm_page_lock_queues();
 	if (error == 0) {
 		KASSERT(tpg->valid == VM_PAGE_BITS_ALL,
 		    ("parts of tpg invalid"));
 		vm_page_dirty(tpg);
 	}
+	vm_page_lock(tpg);
 	vm_page_unwire(tpg, TRUE);
-	vm_page_unlock_queues();
 	vm_page_unlock(tpg);
 	vm_page_wakeup(tpg);
 	if (vpg != NULL)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006160041.o5G0fLvZ041271>