Date: Wed, 06 Oct 2004 09:52:12 -0700 From: Nate Lawson <nate@root.org> To: Maxim Maximov <mcsi@mcsi.pp.ru> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libthr/threadthr_exit.csrc/sys/compat/freebsd32 syscalls.master src/sys/kern kern_thr.c src/sys/sys thr.h Message-ID: <416422BC.8030805@root.org> In-Reply-To: <416410E5.7000405@mcsi.pp.ru> References: <200410061420.i96EKwvd040396@repoman.freebsd.org> <416410E5.7000405@mcsi.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Maximov wrote: > Mike Makonnen wrote: > >> mtm 2004-10-06 14:20:58 UTC >> >> FreeBSD src repository >> >> Modified files: >> lib/libthr/thread thr_exit.c sys/compat/freebsd32 >> syscalls.master sys/kern kern_thr.c >> sys/sys thr.h Log: >> Close a race between a thread exiting and the freeing of it's stack. >> After some discussion the best option seems to be to signal the >> thread's >> death from within the kernel. This requires that thr_exit() take an >> argument. >> Discussed with: davidxu, deischen, marcel >> MFC after: 3 days > > > Just cvsupped source fails to build: > > cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline > -Wcast-qual -fformat-extensions -std=c99 -g -nostdinc -I- -I. > -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica > -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter > -I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath > -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm > -D_KERNEL -include opt_global.h -fno-common -finline-limit=8000 --param > inline-unit-growth=100 --param large-function-growth=1000 > -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding > -Werror /usr/src/sys/kern/kern_thr.c > /usr/src/sys/kern/kern_thr.c: In function `thr_exit': > /usr/src/sys/kern/kern_thr.c:196: error: structure has no member named > `state' > /usr/src/sys/kern/kern_thr.c:197: error: structure has no member named > `state' > *** Error code 1 > > Stop in /usr/obj/usr/src/sys/ULTRA. > *** Error code 1 > > Stop in /usr/src. > *** Error code 1 > > Stop in /usr/src. > Exit 1 It's because of the +0 -0 stuff in the commit. I think he did commit -f without regenerating the syscall table. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?416422BC.8030805>