Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 May 2002 16:10:24 +0300
From:      Peter Pentchev <roam@ringlet.net>
To:        Dag-Erling Smorgrav <des@ofug.org>
Cc:        Giorgos Keramidas <keramida@ceid.upatras.gr>, Bruce Evans <bde@zeta.org.au>, Mike Makonnen <makonnen@pacbell.net>, freebsd-audit@FreeBSD.ORG
Subject:   Re: RFC: Port of NetBSD cat(1)'s -f option.
Message-ID:  <20020516161024.G349@straylight.oblivion.bg>
In-Reply-To: <xzpptzwtfe2.fsf@flood.ping.uio.no>; from des@ofug.org on Thu, May 16, 2002 at 03:02:13PM %2B0200
References:  <20020515211758.GB68380@hades.hell.gr> <20020516164332.B1704-100000@gamplex.bde.org> <20020516134044.A349@straylight.oblivion.bg> <xzpznz0thma.fsf@flood.ping.uio.no> <20020516152345.E349@straylight.oblivion.bg> <20020516124343.GA93634@hades.hell.gr> <xzpptzwtfe2.fsf@flood.ping.uio.no>

next in thread | previous in thread | raw e-mail | index | archive | help

--5L6AZ1aJH5mDrqCQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 16, 2002 at 03:02:13PM +0200, Dag-Erling Smorgrav wrote:
> Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
> > I'm not sure.  The < 0 check is almost hardwired in my fingers,
> > because of a few years of writing it this way.  Just trying to be on
> > the safe side of the world, I guess.
>=20
> It's also a single instruction (+ a flag check) on most architectures,
> while an explicit comparison is at least two, and possibly trashes a
> register.
>=20
> That being said, I use =3D=3D -1 myself - but I don't think < 0 is wrong,
> just different.  As long as we're consistent, I don't care.

It was exactly about being consistent that I first brought this up;
IMO, at least within FreeBSD, being consistent would be =3D=3D -1.

G'luck,
Peter

--=20
Peter Pentchev	roam@ringlet.net	roam@FreeBSD.org
PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
What would this sentence be like if it weren't self-referential?

--5L6AZ1aJH5mDrqCQ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iD8DBQE846+/7Ri2jRYZRVMRAnP1AJ9ceMF/6Vf6EF7Odn9KEYMnuDyuqgCeOFZD
cDM/GMWWQYaTP7GjeR938Ck=
=LwcT
-----END PGP SIGNATURE-----

--5L6AZ1aJH5mDrqCQ--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020516161024.G349>