Date: Wed, 09 Jun 2004 11:02:24 -0600 From: Scott Long <scottl@freebsd.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: arch@freebsd.org Subject: Re: dev_t / udev_t confusion ? Message-ID: <40C742A0.5090704@freebsd.org> In-Reply-To: <55790.1086796559@critter.freebsd.dk> References: <55790.1086796559@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp wrote: > In message <53993.1086779790@critter.freebsd.dk>, Poul-Henning Kamp writes: > > >>The change proposed is more or less to do: >> s/dev_t/struct cdev */ >> s/udev_t/dev_t/ >>over all the kernel sources (366 files or so). > > > Looks like a "yea" so far, so I have a couple of follow-up questions: > > struct cdev currently has members named si_* because it > used to be called "specinfo", do we want to change that > inconsistency at the same time ? (either by reverting to > the specinfo name or by changing to a cd_ prefix ? Sounds fine to me. No prefix at all would work too. > > cdevsw->ioctl() takes a caddr_t pointer argument which > really should be a void *, do we want to change that > as well (since it is all the same files we'll have to > change). > Is this going to have any consequences on COMPAT_LINUX code or anything else that calls ioctl() through obscure means? Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40C742A0.5090704>