Date: Wed, 20 Oct 2021 13:42:37 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: Slawa Olhovchenkov <slw@zxy.spb.ru> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 225639e7db68 - main - vt: Disable bell by default Message-ID: <20211020134237.17596440e1fabda5d40f6985@bidouilliste.com> In-Reply-To: <20211020095206.GA77338@zxy.spb.ru> References: <202110190738.19J7cFtw067994@gitrepo.freebsd.org> <20211019112132.GC80160@zxy.spb.ru> <20211019133700.77c0ca7ac488eb99df50551b@bidouilliste.com> <20211020095206.GA77338@zxy.spb.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 20 Oct 2021 12:52:06 +0300 Slawa Olhovchenkov <slw@zxy.spb.ru> wrote: > On Tue, Oct 19, 2021 at 01:37:00PM +0200, Emmanuel Vadot wrote: > > > On Tue, 19 Oct 2021 14:21:33 +0300 > > Slawa Olhovchenkov <slw@zxy.spb.ru> wrote: > > > > > On Tue, Oct 19, 2021 at 07:38:15AM +0000, Emmanuel Vadot wrote: > > > > > > > The branch main has been updated by manu: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=225639e7db685a4047e384abdbc296c0e02bd147 > > > > > > > > commit 225639e7db685a4047e384abdbc296c0e02bd147 > > > > Author: Emmanuel Vadot <manu@FreeBSD.org> > > > > AuthorDate: 2021-10-18 08:16:41 +0000 > > > > Commit: Emmanuel Vadot <manu@FreeBSD.org> > > > > CommitDate: 2021-10-19 07:37:28 +0000 > > > > > > > > vt: Disable bell by default > > > > > > > > Bell is either useless if you're working on remote servers or really annoying > > > > when you're working with a local machine that have a loud buzzer. > > > > Switch the default to have it disable. > > > > > > For you, not for me, for example. Also, this is violate POLA. > > > > Just set kern.vt.enable_bell=1 in /etc/sysctl.conf and you will be > > happy again. I'll do some UPDATING note. > > And POLA doesn't means that we can't change a thing. > > Modify bsdinstall to set kern.vt.enable_bell=0 in /etc/sysctl.conf, > this is don't break POLA for updating existing install and be happy you. Stop using POLA for "This is a change that I don't agree with". In the past weeks we had commits that changed mixer(8) cli in a non-backward compatible way and changed the root shell. For both you haven't complain so it means that either you don't care or you agree with those changes. I agree that the bell is clearly a user preference and also I could have left the review opened for more time (but I've been there and usually you have review/feedback the first day and after it's silent). I wish there was an easy way for developer (and community member) to create a poll for changes like that but we don't have one right now. Now based on the number of people who reviewed and the people who sent me private message to thanks me for this change I think that more people are annoyed by the bell than people who wants it and we want sane default that most users agrees on in base FreeBSD. If you don't agree with the defaults we have a way to change them. Cheers, -- Emmanuel Vadot <manu@bidouilliste.com> <manu@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20211020134237.17596440e1fabda5d40f6985>