Date: Tue, 12 Jul 2005 14:22:02 +0200 (CEST) From: Sven Berkvens-Matthijsse <sven@ilse.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/83326: [PATCH] audio/vorbis-tools does compile with gcc 2.95 Message-ID: <200507121222.j6CCM2Er019191@serv7.ilse.net> Resent-Message-ID: <200507121230.j6CCUM4k025437@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 83326
>Category: ports
>Synopsis: [PATCH] audio/vorbis-tools does compile with gcc 2.95
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Jul 12 12:30:22 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Sven Berkvens-Matthijsse
>Release: FreeBSD 4.10-STABLE i386
>Organization:
ilse media
>Environment:
System: FreeBSD serv7.ilse.net 4.10-STABLE FreeBSD 4.10-STABLE #23: Wed Aug 4 15:18:52 CEST 2004 root@tango.ilse.net:/usr/obj/usr/src/sys/BAROQUE i386
>Description:
The audio/vorbis-tools port does not compile with gcc 2.95 because
a variable declaration is introduced in a block where this is not
allowed in C90.
>How-To-Repeat:
Try to compile vorbis-tools with gcc 2.95 (FreeBSD 4 default).
>Fix:
The following patch solves the problem (this is the contents of a
new file /usr/ports/audio/vorbis-tools/files/patch-oggenc_encode.c):
--- oggenc/encode.c.orig Tue Jul 12 14:06:35 2005
+++ oggenc/encode.c Tue Jul 12 14:06:40 2005
@@ -160,6 +160,7 @@
/* do we have optional hard bitrate restrictions? */
if(opt->max_bitrate > 0 || opt->min_bitrate > 0){
struct ovectl_ratemanage2_arg ai;
+ long bitrate;
vorbis_encode_ctl(&vi, OV_ECTL_RATEMANAGE2_GET, &ai);
/* libvorbis 1.1 (and current svn) doesn't actually fill this in,
@@ -173,7 +174,6 @@
Also, note that this won't work correctly unless you have a very
recent (2005/03/04 or later) version of libvorbis from svn).
*/
- long bitrate;
{
vorbis_info vi2;
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507121222.j6CCM2Er019191>