Date: Thu, 11 May 2000 15:13:40 -0600 From: Warner Losh <imp@village.org> To: Peter Wemm <peter@netplex.com.au> Cc: nate@yogotech.com (Nate Williams), Garrett Wollman <wollman@khavrinen.lcs.mit.edu>, Greg Lehey <grog@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/vinum list.c Message-ID: <200005112113.PAA02847@harmony.village.org> In-Reply-To: Your message of "Thu, 11 May 2000 11:32:43 PDT." <20000511183243.13AE51CD7@overcee.netplex.com.au> References: <20000511183243.13AE51CD7@overcee.netplex.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20000511183243.13AE51CD7@overcee.netplex.com.au> Peter Wemm writes: : People should use their judgement to strike a balance between descriptive : logs describing an atomic change group over multiple files in a single : commit versus having each file getting an accurate standalone change log. I agree. I think Greg did the right thing here: 1) Commit the changes, one at a time. 2) MFC all at once. Item 1) lets me back out parts if this commit caused me problems if I find that I need to do so. This has been critical in the past when I've had or thought I had vinum problems. Item 2) means that I don't have to see N messages repeated. The only issue that might be argued is that he did a MFC immediately. However, as the primary maintainer[*] with a proven track record during a "lull" period of the stable branch, I think this is well within the accepted and safe practices of the project. I also like the merges that the pc98 folks do where they say: merge from blahblahblah 1.43->1.48. Warner [*] Greg is vinum, despite his removal of MAINTERship in protest. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200005112113.PAA02847>