Date: Sun, 06 Jun 2004 14:14:08 -0400 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: Oliver Eikemeier <eikemeier@fillmore-labs.com> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/portlint Makefile ports/devel/portlint/src portlint.pl Message-ID: <1086545648.34425.6.camel@shumai.marcuscom.com> In-Reply-To: <40C35E35.6080803@fillmore-labs.com> References: <200406060106.i5616XNX076254@repoman.freebsd.org> <40C2CE39.5030402@fillmore-labs.com> <1086541625.34425.1.camel@shumai.marcuscom.com> <40C350AB.2070407@fillmore-labs.com> <1086542154.34425.4.camel@shumai.marcuscom.com> <40C35E35.6080803@fillmore-labs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-VVuv4aAFuYw3gmrQ2nYU Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, 2004-06-06 at 14:11, Oliver Eikemeier wrote: > Joe Marcus Clarke wrote: >=20 > > On Sun, 2004-06-06 at 13:13, Oliver Eikemeier wrote: > >=20 > >>Joe Marcus Clarke wrote: > >> > >>>This was supposed to solve a problem that I've personally hit a few > >>>times. It was just another check to make sure PKGNAME agrees with wha= t > >>>is in distinfo. > >> > >>Could you give me an example? It might be interesting to add this to my > >>rework of the distfiles stuff in PR 67361: > >> <http://people.freebsd.org/~eik/patches/distfiles/>; > >> > >>If it is deemed useful to integrate distinfo into the ports Makefile on= e=20 > >>way or the other, it might not be worth to make efforts to check for=20 > >>stuff that might be obsolete in the future. > >=20 > > For instance, when fixing hyphenated PORTNAMEs, I sometimes forget to > > adjust DISTNAME, and thus the port is broken. I always remember a > > portlint run, but it would never catch the problem. > >=20 > > Joe >=20 > So you need a consistency check without fetching the actual distfiles? > I guess it makes sense to include this into bsd.port.mk, since the > involved code is non-trivial, but the logic is already in place. Should > I add a target to my patch, and what kind of output do you expect? If it's added to bsd.port.mk, then that target should be called by portlint. I guess it would be better to put it in b.p.m since it could be used by more scripts that way. Joe >=20 > -Oliver --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-VVuv4aAFuYw3gmrQ2nYU Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAw17vb2iPiv4Uz4cRAte7AJ9RAK6JQ2vQZnc4+2uy9AMLO4u8SACfa3h6 62I3lG8OQH73QWMFyxLMVAU= =5fFr -----END PGP SIGNATURE----- --=-VVuv4aAFuYw3gmrQ2nYU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1086545648.34425.6.camel>