Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 15 Jul 2001 20:25:05 +0200
From:      Wilko Bulte <wkb@freebie.xs4all.nl>
To:        "David O'Brien" <obrien@FreeBSD.ORG>
Cc:        Jens Schweikhardt <schweikh@schweikhardt.net>, hackers@FreeBSD.ORG
Subject:   Re: Whitespace at end of line
Message-ID:  <20010715202505.A94801@freebie.xs4all.nl>
In-Reply-To: <20010715111956.A71874@dragon.nuxi.com>; from obrien@FreeBSD.ORG on Sun, Jul 15, 2001 at 11:19:57AM -0700
References:  <20010715155941.C1165@schweikhardt.net> <20010715111956.A71874@dragon.nuxi.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 15, 2001 at 11:19:57AM -0700, David O'Brien wrote:
> On Sun, Jul 15, 2001 at 03:59:41PM +0200, Jens Schweikhardt wrote:
> > Dima and /me recently started weeding out white space at end of line for
> > the man pages. I want to widen the weeding to include as much files as
> > possible under /usr/src.
> 
> Please do not do this to the .[ch] files.  It makes diffs to stable harder.
> 
> You may not know this, but in the early history of the "new" CVS tree
> (ie. /home/ncvs vs. /home/cvs) with the 4.4BSD Lite code someone did this
> (including pulling files off the vendor branch).  In the end this has
> really irritated *many* a FreeBSD developer.  Please leave such cleanup to
> when people are in the files cleaning up other style nits so we don't
> have 1 million commits, each taking care of just one point of style(9).
> 
> And as you mentioned in your email, there are cases where you could
> change the semantics.  If one is doing a few files at a time, they can
> catch the semantic changes.  When doing it in-mass using a script, you
> will miss at least one.

Maybe I'm just plain dim today (I will add a beer to rectify this situation
at first convenience..) but what is so bad about some trailing whitespace
that a massive commit-a-thlon is called for?

just wondering,
Wilko
-- 
|   / o / /  _   	Arnhem, The Netherlands    	email: wilko@FreeBSD.org
|/|/ / / /( (_) Bulte	"Youth is not a time in life, it is a state of mind"

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010715202505.A94801>