Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Dec 2017 23:11:23 -0800 (PST)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        "Andrey V. Elsukov" <ae@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r327140 - head/sbin/ipfw
Message-ID:  <201712240711.vBO7BNRG045404@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201712240155.vBO1tCxX099433@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> Author: ae
> Date: Sun Dec 24 01:55:12 2017
> New Revision: 327140
> URL: https://svnweb.freebsd.org/changeset/base/327140
> 
> Log:
>   Fix rule number truncation, use uint16_t type to specify rulenum.
>   
>   PR:		224555
>   MFC after:	1 week
> 
> Modified:
>   head/sbin/ipfw/ipfw2.c
> 
> Modified: head/sbin/ipfw/ipfw2.c
> ==============================================================================
> --- head/sbin/ipfw/ipfw2.c	Sun Dec 24 01:16:28 2017	(r327139)
> +++ head/sbin/ipfw/ipfw2.c	Sun Dec 24 01:55:12 2017	(r327140)
> @@ -2256,12 +2256,13 @@ do_range_cmd(int cmd, ipfw_range_tlv *rt)
>  void
>  ipfw_sets_handler(char *av[])
>  {
> -	uint32_t masks[2];
> -	int i;
> -	uint8_t cmd, rulenum;
>  	ipfw_range_tlv rt;
>  	char *msg;
>  	size_t size;
> +	uint32_t masks[2];
> +	int i;

Why do these 2 lines show up as null changes in the diff????
I can not see any change, not even white space.

> +	uint16_t rulenum;
> +	uint8_t cmd;
>  
>  	av++;
>  	memset(&rt, 0, sizeof(rt));

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201712240711.vBO7BNRG045404>