Date: Sun, 17 Mar 2013 15:27:27 +0000 (UTC) From: Attilio Rao <attilio@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r248424 - user/attilio/vmcontention/sys/vm Message-ID: <201303171527.r2HFRR1f045461@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: attilio Date: Sun Mar 17 15:27:26 2013 New Revision: 248424 URL: http://svnweb.freebsd.org/changeset/base/248424 Log: Expand ambiguous comments some more. Requested by: alc Modified: user/attilio/vmcontention/sys/vm/vm_radix.c Modified: user/attilio/vmcontention/sys/vm/vm_radix.c ============================================================================== --- user/attilio/vmcontention/sys/vm/vm_radix.c Sun Mar 17 15:18:15 2013 (r248423) +++ user/attilio/vmcontention/sys/vm/vm_radix.c Sun Mar 17 15:27:26 2013 (r248424) @@ -35,11 +35,17 @@ * of this code must achieve highest possible performance. * * The implementation takes into account the following rationale: - * - Size of the nodes should be as small as possible. - * - There is no bias toward lookup operations over inserts or removes, - * and vice-versa. - * - On average not many nodes are expected to be full, hence level - * compression may just complicate things. + * - Size of the nodes should be as small as possible but still big enough + * to avoid a large maximum depth for the trie. This is a balance + * between the necessity to not wire too much physical memory for the nodes + * and the necessity to avoid too much cache pollution during the trie + * operations. + * - There is not a huge bias toward the number of lookup operations over + * the number of insert and remove operations. This basically implies + * that optimizations supposedly helping one operation but hurting the + * other might be carefully evaluated. + * - On average not many nodes are expected to be fully populated, hence + * level compression may just complicate things. */ #include <sys/cdefs.h>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303171527.r2HFRR1f045461>