Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 7 Dec 2000 00:15:08 -0800
From:      Alfred Perlstein <alfred@FreeBSD.org>
To:        "David O'Brien" <obrien@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/vm phys_pager.c
Message-ID:  <20001207001508.H16205@fw.wintelcom.net>
In-Reply-To: <20001206235805.A84434@dragon.nuxi.com>; from obrien@FreeBSD.org on Wed, Dec 06, 2000 at 11:58:05PM -0800
References:  <20001205145908.K8051@fw.wintelcom.net> <Pine.SUN.3.91.1001205180108.24320A-100000@pcnet1.pcnet.com> <20001205152054.M8051@fw.wintelcom.net> <3A2EFBC4.EE8D90B1@newsguy.com> <20001206235004.E16205@fw.wintelcom.net> <20001206235805.A84434@dragon.nuxi.com>

next in thread | previous in thread | raw e-mail | index | archive | help
* David O'Brien <obrien@FreeBSD.org> [001206 23:58] wrote:
> On Wed, Dec 06, 2000 at 11:50:04PM -0800, Alfred Perlstein wrote:
> > I am working within the rules of the committers' guide and I will
> > not apologize for trying to fix this broken code, especially when
> > the fix was already reviewed.
> 
> No one said you shouldn't be trying to fix the broken code.  The entire
> issue is the speed of your MFC (which must now be backed out). Got it??

It doesn't do anything, it's already broken.

> > I'm using my judgement and staying within the guidlines while trying
> > to address a serious problem, you however are jumping to conclusions
> > and wasting my time.
> 
> What conclusions???  This is a pretty black and white case from eischen,
> DCS's and my point of view.

I find it hard to believe that you can come to a respectable
conclusion when you have no clue as to what the code is and does.

Y'know what, instead of going into these tirades a much more
productive course of action would be to figure some way to tie in
a keyword we can put into the cvs log messages that will automagically
open a PR to remind us to MFC it.

Since you care so much, I'll leave writing it up to you.

All this damn arguing is exhausting and I just barely remebered
that I'm sitting on a patch to vfs_lookup.c that really ought
to be MFC'd, can you send me a reminder to do so sometime before
the next release?

thanks,
-- 
-Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org]
"I have the heart of a child; I keep it in a jar on my desk."


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001207001508.H16205>