Date: Sat, 18 Dec 2010 20:17:25 +0000 From: Paul B Mahol <onemda@gmail.com> To: Tijl Coosemans <tijl@freebsd.org> Cc: svn-src-head@freebsd.org, Kostik Belousov <kostikbel@gmail.com>, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r216518 - in head/sys/dev: if_ndis le malo sound/pci Message-ID: <AANLkTin3%2BwWzkxzVs8aZC-%2BiZxDB%2BXbPkS-DTgZHuf4G@mail.gmail.com> In-Reply-To: <201012182048.54969.tijl@freebsd.org> References: <201012181421.oBIELTSd093635@svn.freebsd.org> <AANLkTim-9o3XmdeQF1%2BOfR8ToDzHqWyDJOR7sgziz5t5@mail.gmail.com> <201012182048.54969.tijl@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/18/10, Tijl Coosemans <tijl@freebsd.org> wrote: > On Saturday 18 December 2010 19:41:13 Paul B Mahol wrote: >> On 12/18/10, Tijl Coosemans <tijl@freebsd.org> wrote: >>> Author: tijl >>> Date: Sat Dec 18 14:21:28 2010 >>> New Revision: 216518 >>> URL: http://svn.freebsd.org/changeset/base/216518 >>> >>> Log: >>> Use convenience functions where possible instead of accessing the PCI >>> configuration registers directly. >>> >>> Remove pci_enable_io calls where they are redundant. The PCI bus driver >>> will set the right bits when the corresponding bus resource is >>> activated. >>> >>> Remove redundant pci_* function calls from suspend/resume methods. The >>> bus driver already saves and restores the PCI configuration. >>> >>> Reviewed by: jhb >>> Approved by: kib (mentor) >> >> Please revert change to if_ndis regarding introduction of >> pci_get_subvendor(). >> >> You compare 16bit value with 32bit value - this will always fail. > > Apologies. Instead of reverting, would the attached patch work for you? > It moves the function calls out of the while loop and makes it more clear > what subsys means. Looks fine.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTin3%2BwWzkxzVs8aZC-%2BiZxDB%2BXbPkS-DTgZHuf4G>