Date: Tue, 28 Mar 2017 11:42:11 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Warner Losh <imp@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316100 - head/sys/boot/i386/boot2 Message-ID: <6BF9BF65-E700-4176-B405-244D7BA60541@gmail.com> In-Reply-To: <201703281809.v2SI92Ck011780@repo.freebsd.org> References: <201703281809.v2SI92Ck011780@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_41DF7CF7-EF47-4737-9BF5-483E7C7D3B7B Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > On Mar 28, 2017, at 11:09, Warner Losh <imp@freebsd.org> wrote: > > Author: imp > Date: Tue Mar 28 18:09:01 2017 > New Revision: 316100 > URL: https://svnweb.freebsd.org/changeset/base/316100 > > Log: > Remove -fno-guess-branch-probability and -fno-unit-at-a-time. > > bde enabled -fno-guess-branch-probability in 2003, well before our > current compiler was imported. At the time it produced weirdly orded > code. It no longer does that. It also saves 0-4 bytes depending on > other options. > > kan disabled unit-at-a-time in 2004 because it badly mangled boot2 so > it wouldn't work. That too was before the 4.2.1 compiler, where it no > longer does that. This saves 44 bytes. > > I had planned to document why they were needed, but when I discovered > their antiquity, I removed them and boot2 still works and is > smaller. In qemu, the old and new boot2's behaved identically. > > These are gcc specific hacks, and won't affect clang-built boot2 > at all. Nice!!! -Ngie --Apple-Mail=_41DF7CF7-EF47-4737-9BF5-483E7C7D3B7B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY2q6EAAoJEPWDqSZpMIYV9KkQAKYgsd2eQevCUnVCphk7iDvP ivz0TAZQhLTuQy1kbVSus+PfWESwRxhW9bTow+Q2EuTtQDfeSHMLb6eaCB0ZAplS 8GSljOnDeUAFGbtXXz3rDzDBwszKNCz3MLSPxmfJw5SeIVU1bLjNjfgi/REzCZ4F YzgfZAsq67ZhNnaWCT7aO9Icb4ifdWCad87x3SA6GCtKrSzDMETXFm29CuULWw07 hLywLB/o1B1QjcW9QyWNR81XlqnlsxhBbk08Y3dgtQjQ2vq6ZRfumwrVGDfjxPsN lLewXwkxSpnq4uyvDdNjB10DZNxnfXOtrmaQt9zTujW5OpSUONvb9+T1vw24lI17 XxLqOmDA9aXVD84N9S335vWB8P344uGrL9pLnW27+gJolk7LY/pB2+uunZLDJw4h EkMc8od3CgIouvkekIYhwXVNhLpcq8nYC+TLuRzOYP0FTZ+CBlbeFnXG8drmmrdw StNBm0VgGo0yqx/Bo+B7e2ecOuPN4daf6f2Qbhmi1ThfvIAXXhZ+oQoyRxW8Iwgq Ui8D8uCgTw0dN1OKuLjn6KL97koK/ijJ6hji5wdsMysrs9OW2J2ymJ0/G5H5FR5e YdEE5MxGsWV93cREFmjqfkE70EhM0pTZdhugeT4Jm/RyOeMzhfbE43RXlEjjGVNJ wxako3sEJb06++9WHUew =xAap -----END PGP SIGNATURE----- --Apple-Mail=_41DF7CF7-EF47-4737-9BF5-483E7C7D3B7B--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6BF9BF65-E700-4176-B405-244D7BA60541>