Date: Mon, 16 Feb 2004 16:18:35 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: Dag-Erling Smorgrav <des@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_kern.c Message-ID: <20040217001835.GE55055@elvis.mu.org> In-Reply-To: <200402161841.i1GIfwmv008267@repoman.freebsd.org> References: <200402161841.i1GIfwmv008267@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Dag-Erling Smorgrav <des@FreeBSD.org> [040216 10:41] wrote: > des 2004/02/16 10:41:58 PST > > FreeBSD src repository > > Modified files: > sys/vm vm_kern.c > Log: > Don't panic if we fail to satisfy an M_WAITOK request; return 0 instead. > The calling code will either handle that gracefully or cause a page fault. This is really bad idea, please back it out. You are certainly going to get a pagefault in virtually EVERY consumer of malloc. It turns easy to debug calls into a "page fault" ie. "buggy" looking kernel. Bad press, bad idea, back it out, no cookie. :( You go from: "I installed freebsd, exhausted some limits and the machine blew." to: "FreeBSD falls over with 'random' panics when faced with large load." -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040217001835.GE55055>