Date: Thu, 15 Jul 2004 04:52:57 +0000 (UTC) From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/release Makefile Message-ID: <200407150452.i6F4qvGB038786@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jhb 2004-07-15 04:52:57 UTC FreeBSD src repository Modified files: release Makefile Log: Remove some serious foot-shooting potential from the release Makefile. For some unknown reason, when LOCAL_PATCHES and LOCAL_SCRIPT were originally added, they were silently ignored if the actual file did not exist. As a result, if one mistyped the pathname to a patch or script, then the release silently succeeded. However, it was not built with the desired changes and no warning was given to inform the builder either. This commit explicitly checks to see that all of the defined patches and scripts exist up front and bails if any of them do not exist. I lost several hours of valuable sleeping time this evening due to this "feature" so I've finally gone and ripped out. I've tripped over this in the past several other times as well. Glanced at by: scottl Revision Changes Path 1.846 +13 -3 src/release/Makefile
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407150452.i6F4qvGB038786>