Date: Tue, 19 Jul 2016 16:22:33 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Ed Schouten <ed@nuxi.nl> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303046 - head/lib/libc/locale Message-ID: <0273c74d-fc3b-8bf9-9c79-8bc8101943dc@FreeBSD.org> In-Reply-To: <CABh_MK=Pk%2BjxjY8jPu36RraaCfA0O5NzJUEVGJBMYe8ePtfnmQ@mail.gmail.com> References: <201607192022.u6JKMDJD051361@repo.freebsd.org> <CABh_MK=Pk%2BjxjY8jPu36RraaCfA0O5NzJUEVGJBMYe8ePtfnmQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi; On 07/19/16 15:46, Ed Schouten wrote: > Hi Pedro, > > 2016-07-19 22:22 GMT+02:00 Pedro F. Giffuni <pfg@freebsd.org>: >> Author: pfg >> Date: Tue Jul 19 20:22:13 2016 >> New Revision: 303046 >> URL: https://svnweb.freebsd.org/changeset/base/303046 >> >> Log: >> libc: tag the Rune initialization function prototypes visibility as hidden. > > How does this interact with symbol versioning/mapping? Wouldn't our C > library's symbol map already make these symbols hidden without any > explicit annotation? > It shouldn't hurt at all, this is not the first use that we make of the visibility attributes in libc. I do notice we tend to put them at the end of the prototype, while I followed the Apple notation of setting them in front. No idea if that is worthwhile to change. It is true that these symbols should already be hidden but in the case some port is using -fvisibility= compiler flag this will prevent the symbols from getting exported by accident. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0273c74d-fc3b-8bf9-9c79-8bc8101943dc>