Date: Fri, 5 Jan 2001 18:39:02 +0100 From: Brad Knowles <blk@skynet.be> To: Tor.Egge@fast.no Cc: grog@lemis.com, andy.depetter@ops.skynet.be, freebsd-stable@FreeBSD.ORG Subject: Re: Problems with corrupted vinum devices... Message-ID: <v04220811b67bb699c87a@[172.17.1.121]> In-Reply-To: <200101051644.RAA17887@midten.fast.no> References: <v0422080ab67b97176227@[172.17.1.121]> <200101051644.RAA17887@midten.fast.no>
next in thread | previous in thread | raw e-mail | index | archive | help
At 5:44 PM +0100 2001/1/5, Tor.Egge@fast.no wrote: > diff -ru /tmp/vinum/vinumvar.h ./vinumvar.h > --- /tmp/vinum/vinumvar.h Mon May 22 18:21:37 2000 > +++ ./vinumvar.h Thu Jan 4 19:12:01 2001 > @@ -158,15 +158,15 @@ > * probably too small. > */ > > - INITIAL_DRIVES = 4, > + INITIAL_DRIVES = 16, > INITIAL_VOLUMES = 4, > INITIAL_PLEXES = 8, > INITIAL_SUBDISKS = 16, > - INITIAL_SUBDISKS_IN_PLEX = 4, /* number of >subdisks to allocate to a plex */ > + INITIAL_SUBDISKS_IN_PLEX = 16, /* number of >subdisks to allocate to a plex */ > INITIAL_SUBDISKS_IN_DRIVE = 4, /* number of >subdisks to allocate to a drive */ > INITIAL_DRIVE_FREELIST = 16, /* number of entries >in drive freelist */ > PLEX_REGION_TABLE_SIZE = 8, /* number of >entries in plex region tables */ > - INITIAL_LOCKS = 256, /* number of locks to >allocate to a plex */ > + INITIAL_LOCKS = 4096, /* number of locks to >allocate to a plex */ > MAX_REVIVE_BLOCKSIZE = MAXPHYS, /* maximum revive >block size */ > DEFAULT_REVIVE_BLOCKSIZE = 65536, /* default >revive block size */ > VINUMHOSTNAMELEN = 32, /* host name field in label */ Let's look again at the full comment block before this segment of code: | /* | * the number of object entries to cater for initially, and also the | * value by which they are incremented. It doesn't take long | * to extend them, so theoretically we could start with 1 of each, but | * it's untidy to allocate such small areas. These values are | * probably too small. | */ Theoretically, changing the initial values should have no impact whatsoever on the ability (or lack thereof) to create devices, so long as you're not exceeding the specified maximums. Vinum should automatically extend the necessary data structures beyond these initial defaults, if the need should arise. If vinum isn't doing this, then the code to do those extensions is faulty and it should be fixed instead. The more I think about this, the less I think that this has anything at all to do with either the problems you experienced, or the problems we're having. -- These are my opinions -- not to be taken as official Skynet policy ====================================================================== Brad Knowles, <blk@skynet.be> || Belgacom Skynet SA/NV Systems Architect, Mail/News/FTP/Proxy Admin || Rue Colonel Bourg, 124 Phone/Fax: +32-2-706.13.11/12.49 || B-1140 Brussels http://www.skynet.be || Belgium "They that can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety." -Benjamin Franklin, Historical Review of Pennsylvania. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?v04220811b67bb699c87a>