Date: Tue, 31 Mar 2020 17:28:21 +0200 From: "Kristof Provost" <kp@FreeBSD.org> To: "Mark Johnston" <markj@freebsd.org> Cc: "Li-Wen Hsu" <lwhsu@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r359436 - in head/sys: kern net sys Message-ID: <9A4C20AA-8E13-47C8-B162-F2304F8C79B7@FreeBSD.org> In-Reply-To: <20200331151700.GC97238@raichu> References: <202003301422.02UEMrxL059978@repo.freebsd.org> <CAKBkRUxrzmqkDrsPXLWr%2B5d6djghR1jbr_Lg5RpvpanAzOxtKw@mail.gmail.com> <20200331015905.GC65028@raichu> <20200331023127.GA97238@raichu> <CAKBkRUyi5At9bwXAH7Sw3xb=KZXTBHOpjpuRKvAMhbxpnSwb2A@mail.gmail.com> <D538EC06-2F66-4638-BD1A-65B27B16C35A@FreeBSD.org> <CAKBkRUwr1L4iO_%2BY4aNupXQCuFsSHtO-Y1L=PQbPKmYMU=tpcA@mail.gmail.com> <20200331151700.GC97238@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31 Mar 2020, at 17:17, Mark Johnston wrote: > On Tue, Mar 31, 2020 at 03:51:27PM +0800, Li-Wen Hsu wrote: >> On Tue, Mar 31, 2020 at 3:00 PM Kristof Provost <kp@freebsd.org> >> wrote: >>> >>> On 31 Mar 2020, at 7:56, Li-Wen Hsu wrote: >>>> On Tue, Mar 31, 2020 at 10:55 AM Mark Johnston <markj@freebsd.org> >>>> wrote: >>>>>>> It seems could be triggered by sys.netinet6.frag6.* >>>>>>> sys.netpfil.common.* sbin.pfctl.pfctl_test.* tests, and there >>>>>>> are lots >>>>>>> of test cases timed out. >>>>>>> >>>>>>> Can you help check these? >>>>>> >>>>>> I see, it is actually caused by r359438. I'm looking at it now. >>>>> >>>>> I verified that the netpfil and netinet6 tests pass with r359477. >>>> >>>> Thanks for the fixing, the latest test panics at epair_qflush: >>>> >>>> https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14747/consoleFull >>>> >>>> while executing sys.netpfil.pf.* tests. I'm not sure if this is >>>> related or because of previous commits (I suspect the later). I'll >>>> look into this. >>>> >>> That’s a know issue with epair (since EPOCH, I believe). >>> A number of the pf tests are disabled due to this. See 238870. >> >> I also think so, btw, currently every test run panics so I am afraid >> that the recent commits might make status worse (or say, make the >> issue easier to reproduce?) > > I haven't been able to reproduce any panics or test failures so far. Once you disable the ‘atf_skip’ lines in the pf tests a simple `sudo kldload pfsync && cd /usr/tests/sys/netpfil/pf && sudo kyua test` is likely sufficient. There’s a complex race around tearing down epair interfaces and moving them back to their home vnet that’s proven very tricky to resolve. Best regards, Kristof From owner-svn-src-all@freebsd.org Tue Mar 31 15:45:43 2020 Return-Path: <owner-svn-src-all@freebsd.org> Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8C45E261412; Tue, 31 Mar 2020 15:45:43 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48sDF24MQXz445K; Tue, 31 Mar 2020 15:45:42 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 459D4BFEE; Tue, 31 Mar 2020 15:28:32 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 02VFSWmG076619; Tue, 31 Mar 2020 15:28:32 GMT (envelope-from kib@FreeBSD.org) Received: (from kib@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 02VFSWvA076618; Tue, 31 Mar 2020 15:28:32 GMT (envelope-from kib@FreeBSD.org) Message-Id: <202003311528.02VFSWvA076618@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: kib set sender to kib@FreeBSD.org using -f From: Konstantin Belousov <kib@FreeBSD.org> Date: Tue, 31 Mar 2020 15:28:32 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r359485 - stable/11/sys/dev/sound/pci/hda X-SVN-Group: stable-11 X-SVN-Commit-Author: kib X-SVN-Commit-Paths: stable/11/sys/dev/sound/pci/hda X-SVN-Commit-Revision: 359485 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>; List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Tue, 31 Mar 2020 15:45:43 -0000 Author: kib Date: Tue Mar 31 15:28:31 2020 New Revision: 359485 URL: https://svnweb.freebsd.org/changeset/base/359485 Log: MFC r359396: hdaa: remove verbosity from the normal driver operations. Modified: stable/11/sys/dev/sound/pci/hda/hdac.c Directory Properties: stable/11/ (props changed) Modified: stable/11/sys/dev/sound/pci/hda/hdac.c ============================================================================== --- stable/11/sys/dev/sound/pci/hda/hdac.c Tue Mar 31 15:26:56 2020 (r359484) +++ stable/11/sys/dev/sound/pci/hda/hdac.c Tue Mar 31 15:28:31 2020 (r359485) @@ -1409,21 +1409,11 @@ hdac_poll_reinit(struct hdac_softc *sc) pollticks >>= 1; if (pollticks > hz) pollticks = hz; - if (pollticks < 1) { - HDA_BOOTVERBOSE( - device_printf(sc->dev, - "poll interval < 1 tick !\n"); - ); + if (pollticks < 1) pollticks = 1; - } if (min > pollticks) min = pollticks; } - HDA_BOOTVERBOSE( - device_printf(sc->dev, - "poll interval %d -> %d ticks\n", - sc->poll_ival, min); - ); sc->poll_ival = min; if (min == 1000000) callout_stop(&sc->poll_callout);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9A4C20AA-8E13-47C8-B162-F2304F8C79B7>