Date: Thu, 19 Aug 1999 12:29:07 +0000 (GMT) From: Alfred Perlstein <bright@wintelcom.net> To: Daniel Eischen <eischen@vigrid.com> Cc: alfred@FreeBSD.org, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Fabian Thylmann <fthylmann@stats.net> Subject: Re: cvs commit: src/lib/libc_r/uthread uthread_kern.c Message-ID: <Pine.BSF.4.05.9908191224440.6392-100000@fw.wintelcom.net> In-Reply-To: <199908191747.NAA21199@pcnet1.pcnet.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 19 Aug 1999, Daniel Eischen wrote: > > alfred 1999/08/19 09:49:54 PDT > > > > Modified files: > > lib/libc_r/uthread uthread_kern.c > > Log: > > handle under/overflow of time values in a more robust manner, > > there may be an overflow that need to be adjusted more than once. > > I think this is a coverup for the real problem. Timevals and Timespecs > should be validated in pthread_cond_timedwait(), select(), nanosleep(), > etc, and errno set appropriately (EINVAL returned for pthread_cond_timedwait). > Correcting for the subtraction of two _valid_ tv_nsec fields should only > need to be done once. I'm not too sure, the checking of overflow that was there previously was insufficient, i've talked to the person experiancing the bug and they don't use pthread_cond_timedwait, and i doubt that they are using sleep and/or select. there should be a catch for invalid time passed to the cond_timedwait function though. I'm cc'ing the person who is experiancing the bug. Fabian: are you using anything in your code that uses time structures? (select/sleep)? may I commit a check akin to the one in nanosleep to catch negative/ out-of-range time values? thanks, -Alfred Perlstein - [bright@rush.net|alfred@freebsd.org] Wintelcom systems administrator and programmer - http://www.wintelcom.net/ [bright@wintelcom.net] To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9908191224440.6392-100000>