Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 May 2013 11:00:55 -0700
From:      Tim Kientzle <kientzle@freebsd.org>
To:        apache@freebsd.org
Subject:   devel/apr1 on FreeBSD/ARM/clang
Message-ID:  <C3A6842E-5C94-430D-B6CF-A64C0F5F3E8E@freebsd.org>

next in thread | raw e-mail | index | archive | help

--Apple-Mail=_56BC8D65-269D-48F1-83DA-EF7987518268
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_1D10DD3C-2B78-4F25-B78D-DF32B020C7E6"


--Apple-Mail=_1D10DD3C-2B78-4F25-B78D-DF32B020C7E6
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Flattered as I am that my little ARM board is being compared to a Cray, =
I'd much rather that devel/apr1 actually built.  ;-)

The attached patch file fixes devel/apr1 when built on =
FreeBSD/ARM/clang.  I have not tested it with GCC or Clang/OABI, though =
since this just changes the logic to use the same offsetof calculation =
as Linux, I presume it works on GCC as well:


--Apple-Mail=_1D10DD3C-2B78-4F25-B78D-DF32B020C7E6
Content-Disposition: attachment;
	filename=patch-apr__include__apr_general.h
Content-Type: application/octet-stream;
	name="patch-apr__include__apr_general.h"
Content-Transfer-Encoding: 7bit

--- ./apr-1.4.6/include/apr_general.h.orig	2011-11-04 02:54:27.000000000 +0000
+++ ./apr-1.4.6/include/apr_general.h	2013-05-11 02:30:23.000000000 +0000
@@ -76,7 +76,7 @@
  * @return offset
  */
 
-#if defined(CRAY) || (defined(__arm) && !defined(LINUX))
+#if defined(CRAY)
 #ifdef __STDC__
 #define APR_OFFSET(p_type,field) _Offsetof(p_type,field)
 #else

--Apple-Mail=_1D10DD3C-2B78-4F25-B78D-DF32B020C7E6
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii



A more suitable patch for upstream would probably add !defined(FreeBSD) =
instead.

Tim


--Apple-Mail=_1D10DD3C-2B78-4F25-B78D-DF32B020C7E6--

--Apple-Mail=_56BC8D65-269D-48F1-83DA-EF7987518268
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.18 (Darwin)

iQEcBAEBAgAGBQJRjodZAAoJEGMNyGo0rfFBvJQH/1ndneB+fDu03vxOt5LNRruL
sjnwd0UVwsC3jsmE54U1WtYXLt6Il4HLcFRnMkknyRhEpJQDsIzuQWjYK0M3LcQC
MRAO+jyk3o+mAm1jZeXfRoG1QnyspR5Otrl5tE5botfxFOl6iDni3CMAzeNSofgh
FBAY/CUjfV09uNHGUqQ7kSgJauE2Z9EY9vLE3YPH7aD/AoGROU1Hmh6vlhdSALRy
6tMW2OHCxLP8hessE8Rq0/nicUBMunf/wrqm0iyjhACz+LH1lqJcv6nOXGrGpWSd
2S3n1bQMSSRKXl7cLVlqr2oxvZhnb99Ec9Apidp7Q18gD7fPFvNzValPbNovSi0=
=oeOj
-----END PGP SIGNATURE-----

--Apple-Mail=_56BC8D65-269D-48F1-83DA-EF7987518268--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C3A6842E-5C94-430D-B6CF-A64C0F5F3E8E>