Date: Tue, 17 Mar 2020 08:38:04 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Gleb Popov <arrowd@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r528542 - head/Mk/Uses Message-ID: <20200317073804.gosvmke23hjtphyj@atuin.in.mat.cc> In-Reply-To: <CALH631k64rHFOHTNTkqtTs4cNf4GR8Sjnffa5YxVE950WneDWQ@mail.gmail.com> References: <202003161959.02GJxRUw033181@repo.freebsd.org> <20200316200618.ogsgwf6n4sdye5ry@aching.in.mat.cc> <CALH631k64rHFOHTNTkqtTs4cNf4GR8Sjnffa5YxVE950WneDWQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--zfbbamqs62zixi2b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 17, 2020 at 10:58:50AM +0400, Gleb Popov wrote: > On Tue, Mar 17, 2020 at 12:06 AM Mathieu Arnold <mat@freebsd.org> wrote: >=20 > > On Mon, Mar 16, 2020 at 07:59:27PM +0000, Gleb Popov wrote: > > > Author: arrowd > > > Date: Mon Mar 16 19:59:27 2020 > > > New Revision: 528542 > > > URL: https://svnweb.freebsd.org/changeset/ports/528542 > > > > > > Log: > > > Mk/Uses/cabal.mk: Wrap *.cabal argument in ticks. > > > > Why? > > >=20 > This fixed build for port I was working on. I don't have a reproducer > anymore. >=20 > Is this change bad? I have no idea about the change. What was bad is the commit message. A commit message is where you record for the history WHY something was done, so that when someone looks at it later, they can understand why it was done. A commit message cannot be the diff translated to english, because it does not explain why the change was made, why it was necessary, what it was fixing. >=20 > > > Modified: > > > head/Mk/Uses/cabal.mk > > > > > > Modified: head/Mk/Uses/cabal.mk > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/Mk/Uses/cabal.mk Mon Mar 16 19:57:41 2020 (r52854= 1) > > > +++ head/Mk/Uses/cabal.mk Mon Mar 16 19:59:27 2020 (r52854= 2) > > > @@ -141,7 +141,7 @@ make-use-cabal-revs: > > > cabal-post-extract: > > > . for package in ${_use_cabal} > > > . if ${package:C/[^_]*//:S/_//} !=3D "" > > > - cp > > ${DISTDIR}/${DIST_SUBDIR}/${package:C/_[0-9]+//}/revision/${package:C/[= ^_]*//:S/_//}.cabal > > `find ${WRKDIR}/${package:C/_[0-9]+//} -name *.cabal -depth 1` > > > + cp > > ${DISTDIR}/${DIST_SUBDIR}/${package:C/_[0-9]+//}/revision/${package:C/[= ^_]*//:S/_//}.cabal > > `find ${WRKDIR}/${package:C/_[0-9]+//} -name '*.cabal' -depth 1` > > > . endif > > > cd ${WRKDIR} && \ > > > mv ${package:C/_[0-9]+//} ${WRKSRC}/ > > > > > > > -- > > Mathieu Arnold > > --=20 Mathieu Arnold --zfbbamqs62zixi2b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl5wflxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkigAA//cIh7qGTLmwFhov4pCHg3zhwOxsSW/v8mnWIbiOVTGAnifoU++2EY1zpf 3BW+6lOkbKc5RZWzPuah/BKojttdWkLSLd+9o4m1BPMsDjBXdD+vNAXXzXIDM0hn hiUSoEpKF7lDzD9PvxGrIN1aGxrPovOwKemTL6BOaZP/b7E5ECgwJBbqJY4yWQHe ohWU4etWT0qt1erOD7p46aGznaWietQlcTwWX2muHu2cyoE0FC6eBd7QX1KMvJmi nCvAicmApAAtZU9ApOaGFWWLu45I1KhJCt9taq/Q8DcmfZpSMncQzAIFMYvJm0zr P1ku79+GGRNJTkKCq20+2DTXneUu8kiNrKV0/q+KfODHCcyeFeRtXmazk10f+dFR 6eCzacwUwzAkoNyoZcq37Tvr9zFmbACrpcmu2wqzpI0k4W0fTnyVR1lk4nQf+zzY /JRzrkM8THBGtD8eLtYfdhzVWV+rGpDysx46vNJOBTIGzq4/FIEuVCzJGxJHJH4s 8Py3WLsx1J+FiEq6PgPXNN+MwBp4eoF6rtgMK2Z/1OseApfwcoqKR8YD35BhlBiX FL4vDS8oMVKNGC62QVFclDgVJJUW4TMLk0+toUnBDxdnIK8nre/v28b7YwqUav3h 1BSiRsEVOcghCgWBzYKGVJh+LaCds7JS2nBdAL8l7U/Xt+Mikas= =fefQ -----END PGP SIGNATURE----- --zfbbamqs62zixi2b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200317073804.gosvmke23hjtphyj>