Date: Wed, 23 Jun 2010 13:19:49 -0400 From: John Baldwin <jhb@freebsd.org> To: Alexandre Fiveg <afiveg@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 179713 for review Message-ID: <201006231319.49258.jhb@freebsd.org> In-Reply-To: <201006171446.o5HEkRSP022515@repoman.freebsd.org> References: <201006171446.o5HEkRSP022515@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 17 June 2010 10:46:27 am Alexandre Fiveg wrote: > http://p4web.freebsd.org/@@179713?ac=10 > > Change 179713 by afiveg@cottonmouth on 2010/06/17 14:46:03 > > Begin with new design for ringmap: > 1. The new structure with pointers to hardware dependent functions: > "struct ringmap_functions" (/net/ringmap.h) > 2. Pointer to this structure placed in ringmap structure. > 3. In the ringmap_attach function look for pci Id of network controller, > and then, depending on controllers type, initialize the functions pointers: > (ringmap.c: set_ringmap_funcs()) I think 3) is the wrong way to go about it. Can't you have the NIC driver attach a ringmap and supply the function pointers to the NIC-specific functionality instead? You really don't want to have two separate lists of device IDs. The ringmap list will invariably become stale. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006231319.49258.jhb>