Date: Thu, 1 Dec 2011 11:48:22 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "Sergey A. Osokin" <osa@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Pietro Cerutti <gahr@FreeBSD.org> Subject: Re: [ports] cvs commit: ports/devel/glui Makefile ports/devel/glui/files patch-makefile Message-ID: <20111201114822.GA63988@FreeBSD.org> In-Reply-To: <20111201110523.GA17923@FreeBSD.org> References: <201112011044.pB1Aiql7047544@repoman.freebsd.org> <20111201104500.30DC91065789@hub.freebsd.org> <20111201110523.GA17923@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 01, 2011 at 11:05:23AM +0000, Sergey A. Osokin wrote:
> On Thu, Dec 01, 2011 at 10:45:00AM +0000, Pietro Cerutti wrote:
> > gahr 2011-12-01 10:44:52 UTC
> >
> > Modified files:
> > devel/glui Makefile
> > devel/glui/files patch-makefile
> > Log:
> > - Build and install shared library as well
> >
> > Feature safe: yes
> >
> > Index: ports/devel/glui/Makefile
> > diff -u ports/devel/glui/Makefile:1.13 ports/devel/glui/Makefile:1.14
> > --- ports/devel/glui/Makefile:1.13 Tue Feb 9 19:39:53 2010
> > +++ ports/devel/glui/Makefile Thu Dec 1 10:44:52 2011
> > @@ -21,12 +21,13 @@
> >
> > WRKSRC= ${WRKDIR}/${DISTNAME}/src
> >
> > -PLIST_FILES= include/glui.h lib/libglui.a
> > +PLIST_FILES= include/glui.h lib/libglui.a lib/libglui.so
> > PORTDOCS= *
> >
> > do-install:
> > ${INSTALL_DATA} ${WRKSRC}/include/GL/glui.h ${PREFIX}/include/
> > ${INSTALL_DATA} ${WRKSRC}/lib/libglui.a ${PREFIX}/lib/
> > + ${INSTALL_DATA} ${WRKSRC}/lib/libglui.so ${PREFIX}/lib/
> > .if !defined(NOPORTDOCS)
> > ${MKDIR} ${DOCSDIR}
> > ${INSTALL_DATA} ${WRKSRC}/doc/glui_manual.pdf ${DOCSDIR}/
>
> Could you please bump PORTREVISION due to package and pkg-list changes?
While normally, since both old and new packages have correct pkg-list,
bumping PORTREVISION is not necessary, in this case it might be required if
this is dependent port, and consumers might want to link to newly installed
shared library (that is, if previously installed version would not work).
Maintainers of affected ports should take a closer look into this.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111201114822.GA63988>