Date: Mon, 16 Sep 2019 16:10:44 +0000 (UTC) From: Yuri Pankov <yuripv@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r352415 - stable/12/sys/dev/ichsmb Message-ID: <201909161610.x8GGAihM095902@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: yuripv Date: Mon Sep 16 16:10:44 2019 New Revision: 352415 URL: https://svnweb.freebsd.org/changeset/base/352415 Log: MFC r351604: ichsmb: defer smbus attach until interrupts are available This fixes a "timed sleep before timers are working" panic seen while attaching jedec_dimm(4) instances too early in the boot. Submitted by: ian Reviewed by: hselasky Differential Revision: https://reviews.freebsd.org/D21452 Modified: stable/12/sys/dev/ichsmb/ichsmb.c Directory Properties: stable/12/ (props changed) Modified: stable/12/sys/dev/ichsmb/ichsmb.c ============================================================================== --- stable/12/sys/dev/ichsmb/ichsmb.c Mon Sep 16 15:56:21 2019 (r352414) +++ stable/12/sys/dev/ichsmb/ichsmb.c Mon Sep 16 16:10:44 2019 (r352415) @@ -131,11 +131,8 @@ ichsmb_attach(device_t dev) goto fail; } - /* Attach "smbus" child */ - if ((error = bus_generic_attach(dev)) != 0) { - device_printf(dev, "failed to attach child: %d\n", error); - goto fail; - } + /* Probe and attach the smbus when interrupts are available */ + config_intrhook_oneshot((ich_func_t)bus_generic_attach, dev); return (0);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201909161610.x8GGAihM095902>