Date: Wed, 9 Sep 2020 13:08:23 -0500 From: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r365506 - in head: include lib/libc/gen lib/libc/sys Message-ID: <CACNAnaF8_9ePZ6aaysU64=S2uo-7-TRBmc8zDBF%2BAe5fpy%2BPnw@mail.gmail.com> In-Reply-To: <202009091807.089I7DIv055428@repo.freebsd.org> References: <202009091807.089I7DIv055428@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 9, 2020 at 1:07 PM Kyle Evans <kevans@freebsd.org> wrote: > > Author: kevans > Date: Wed Sep 9 18:07:13 2020 > New Revision: 365506 > URL: https://svnweb.freebsd.org/changeset/base/365506 > > Log: > getlogin_r: fix the type of len > > getlogin_r is specified by POSIX to to take a size_t len, not int. Fix our > version to do the same, bump the symbol version due to ABI change and > provide compat. > > This was reported to break compilation of Ruby 2.8. > > Some discussion about the necessity of the ABI compat did take place in the > review. While many 64-bit platforms would likely be passing it in a 64-bit > register and zero-extended and thus, not notice ABI breakage, some do > sign-extend (e.g. mips). > > PR: 247102 > Submitted by: Bertram Scharpf <software@bertram-scharpf.de> (original) > Submitted by: cem (ABI compat) > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D26335 > Argh, I dropped this =(: Reviewed by: emaste, jhb, kib
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaF8_9ePZ6aaysU64=S2uo-7-TRBmc8zDBF%2BAe5fpy%2BPnw>