Date: Sat, 12 Aug 2006 00:52:13 +0200 From: Alexander Leidinger <netchild@FreeBSD.org> To: Kris Kennaway <kris@obsecurity.org> Cc: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Ruslan Ermilov <ru@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src ObsoleteFiles.inc Message-ID: <20060812005213.384b744b@Magellan.Leidinger.net> In-Reply-To: <20060811223642.GA21117@xor.obsecurity.org> References: <200608101942.k7AJgOrB051336@repoman.freebsd.org> <20060811235619.G93570@atlantis.atlantis.dp.ua> <20060811220244.GC5237@rambler-co.ru> <20060811223642.GA21117@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Kris Kennaway <kris@obsecurity.org> (Fri, 11 Aug 2006 18:36:42 -0400):
> On Sat, Aug 12, 2006 at 02:02:44AM +0400, Ruslan Ermilov wrote:
> > On Sat, Aug 12, 2006 at 12:04:14AM +0300, Dmitry Pryanishnikov wrote:
> > >
> > > Hello!
> > >
> > > On Thu, 10 Aug 2006, Alexander Leidinger wrote:
> > > >netchild 2006-08-10 19:42:24 UTC
> > > >
> > > > FreeBSD src repository
> > > >
> > > > Modified files:
> > > > . ObsoleteFiles.inc
> > > > Log:
> > > > Add some more files...
> > > >
> > > > List provided by: kris
> > > >
> > > > Revision Changes Path
> > > > 1.44 +201 -0 src/ObsoleteFiles.inc
> > >
> > > This commit re-adds the following files:
> > >
> > > +OLD_FILES+=usr/share/tmac/mm/locale
> > > +OLD_FILES+=usr/share/tmac/mm/se_locale
> > >
> > > which were removed in version 1.26 because at lease mm/locale is actually
> > > required despite being empty (/usr/share/tmac/m.tmac refers it). Thus the
> > > commit reintroduces brokenness of at least x11/XFree86-4-documents port.
> > > Please remove those files. 'make installworld' after 'make delete-old'
> > > recreates them so they must not be listed in ObsoleteFiles.inc.
> > >
> > Fixed, thanks for the report.
>
> I'd suggest adding a comment to the file to prevent another recurrence
This was one the first idea I had after reading this. If nobody comes
up with a better one after I'm awaken again, I will add a comment (at
the end of the OLD_FILES list).
> of this, or make it so they're touched at installworld and don't keep
> showing up as false positives in 'find' searches.
That would be another idea. I like it better, since we can't expect
that someone greps in ObsoleteFiles.inc for each file he wants to add.
Bye,
Alexander.
--
...and that is how we know the Earth to be banana-shaped.
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060812005213.384b744b>