Date: Fri, 3 Sep 2010 08:00:21 GMT From: Andriy Gapon <avg@icyb.net.ua> To: freebsd-acpi@FreeBSD.org Subject: Re: kern/147858: [acpi] acpi_hp not working when loaded via loader.conf Message-ID: <201009030800.o8380LcZ052280@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/147858; it has been noted by GNATS. From: Andriy Gapon <avg@icyb.net.ua> To: bug-followup@FreeBSD.org, maciej@suszko.eu Cc: Rui Paulo <rpaulo@FreeBSD.org> Subject: Re: kern/147858: [acpi] acpi_hp not working when loaded via loader.conf Date: Fri, 03 Sep 2010 10:55:50 +0300 This is a multi-part message in MIME format. --------------080100030005090509050807 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Could originator and other people having the problem please test the attached patch and followup to the PR? Thanks! The patch is only compile-tested by me, because I don't have the hardware. So you might experience crashes or other surprising behavior. But I hope that you won't. -- Andriy Gapon --------------080100030005090509050807 Content-Type: text/plain; name="acpi_hp.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="acpi_hp.diff" ZGlmZiAtLWdpdCBhL3N5cy9kZXYvYWNwaV9zdXBwb3J0L2FjcGlfaHAuYyBiL3N5cy9kZXYv YWNwaV9zdXBwb3J0L2FjcGlfaHAuYwppbmRleCBiMGU4NWJlLi4yNWY5OTJjIDEwMDY0NAot LS0gYS9zeXMvZGV2L2FjcGlfc3VwcG9ydC9hY3BpX2hwLmMKKysrIGIvc3lzL2Rldi9hY3Bp X3N1cHBvcnQvYWNwaV9ocC5jCkBAIC00OSw2ICs0OSw3IEBAIF9fRkJTRElEKCIkRnJlZUJT RCQiKTsKICNpbmNsdWRlIDxzeXMvdWlvLmg+CiAjaW5jbHVkZSA8c3lzL3Byb2MuaD4KICNp bmNsdWRlIDxzeXMva2VybmVsLmg+CisjaW5jbHVkZSA8c3lzL2xpbWl0cy5oPgogI2luY2x1 ZGUgPHN5cy9idXMuaD4KICNpbmNsdWRlIDxzeXMvc2J1Zi5oPgogI2luY2x1ZGUgPHN5cy9t b2R1bGUuaD4KQEAgLTExNiw3ICsxMTcsNiBAQCBzdHJ1Y3QgYWNwaV9ocF9pbnN0X3NlcV9w YWlyIHsKIAogc3RydWN0IGFjcGlfaHBfc29mdGMgewogCWRldmljZV90CWRldjsKLQlBQ1BJ X0hBTkRMRQloYW5kbGU7CiAJZGV2aWNlX3QJd21pX2RldjsKIAlpbnQJCWhhc19ub3RpZnk7 CQkvKiBub3RpZmljYXRpb24gR1VJRCBmb3VuZCAqLwogCWludAkJaGFzX2NtaTsJCS8qIENN SSBHVUlEIGZvdW5kICovCkBAIC0yODksNiArMjg5LDcgQEAgc3RhdGljIHN0cnVjdCB7CiAK IEFDUElfU0VSSUFMX0RFQ0woaHAsICJIUCBBQ1BJLVdNSSBNYXBwaW5nIik7CiAKK3N0YXRp YyB2b2lkCWFjcGlfaHBfaWRlbnRpZnkoZHJpdmVyX3QgKmRyaXZlciwgZGV2aWNlX3QgcGFy ZW50KTsKIHN0YXRpYyBpbnQJYWNwaV9ocF9wcm9iZShkZXZpY2VfdCBkZXYpOwogc3RhdGlj IGludAlhY3BpX2hwX2F0dGFjaChkZXZpY2VfdCBkZXYpOwogc3RhdGljIGludAlhY3BpX2hw X2RldGFjaChkZXZpY2VfdCBkZXYpOwpAQCAtMzIwLDYgKzMyMSw3IEBAIHN0YXRpYyBzdHJ1 Y3QgY2RldnN3IGhwY21pX2NkZXZzdyA9IHsKIH07CiAKIHN0YXRpYyBkZXZpY2VfbWV0aG9k X3QgYWNwaV9ocF9tZXRob2RzW10gPSB7CisJREVWTUVUSE9EKGRldmljZV9pZGVudGlmeSwg YWNwaV9ocF9pZGVudGlmeSksCiAJREVWTUVUSE9EKGRldmljZV9wcm9iZSwgYWNwaV9ocF9w cm9iZSksCiAJREVWTUVUSE9EKGRldmljZV9hdHRhY2gsIGFjcGlfaHBfYXR0YWNoKSwKIAlE RVZNRVRIT0QoZGV2aWNlX2RldGFjaCwgYWNwaV9ocF9kZXRhY2gpLApAQCAtNDA1LDcgKzQw Nyw3IEBAIGFjcGlfaHBfZXZhbHVhdGVfYXV0b19vbl9vZmYoc3RydWN0IGFjcGlfaHBfc29m dGMgKnNjKQogCQkJICAgIAkgICAgIldMQU4gb24gYWlyIGNoYW5nZWQgdG8gJWkgIgogCQkJ ICAgIAkgICAgIihuZXdfd2xhbl9zdGF0dXMgaXMgJWkpXG4iLAogCQkJICAgIAkgICAgc2Mt Pndhc193bGFuX29uX2FpciwgbmV3X3dsYW5fc3RhdHVzKTsKLQkJCWFjcGlfVXNlck5vdGlm eSgiSFAiLCBzYy0+aGFuZGxlLAorCQkJYWNwaV9Vc2VyTm90aWZ5KCJIUCIsIEFDUElfUk9P VF9PQkpFQ1QsCiAJCQkgICAgMHhjMCtzYy0+d2FzX3dsYW5fb25fYWlyKTsKIAkJfQogCX0K QEAgLTQyMCw3ICs0MjIsNyBAQCBhY3BpX2hwX2V2YWx1YXRlX2F1dG9fb25fb2ZmKHN0cnVj dCBhY3BpX2hwX3NvZnRjICpzYykKIAkJCQkgICAgIiB0byAlaSAobmV3X2JsdWV0b290aF9z dGF0dXMgaXMgJWkpXG4iLAogCQkJCSAgICBzYy0+d2FzX2JsdWV0b290aF9vbl9haXIsCiAJ CQkJICAgIG5ld19ibHVldG9vdGhfc3RhdHVzKTsKLQkJCWFjcGlfVXNlck5vdGlmeSgiSFAi LCBzYy0+aGFuZGxlLAorCQkJYWNwaV9Vc2VyTm90aWZ5KCJIUCIsIEFDUElfUk9PVF9PQkpF Q1QsCiAJCQkgICAgMHhkMCtzYy0+d2FzX2JsdWV0b290aF9vbl9haXIpOwogCQl9CiAJfQpA QCAtNDMzLDE2ICs0MzUsNDMgQEAgYWNwaV9ocF9ldmFsdWF0ZV9hdXRvX29uX29mZihzdHJ1 Y3QgYWNwaV9ocF9zb2Z0YyAqc2MpCiAJCQkJICAgICJXV0FOIG9uIGFpciBjaGFuZ2VkIHRv ICVpIgogCQkJICAgIAkgICAgIiAobmV3X3d3YW5fc3RhdHVzIGlzICVpKVxuIiwKIAkJCQkg ICAgc2MtPndhc193d2FuX29uX2FpciwgbmV3X3d3YW5fc3RhdHVzKTsKLQkJCWFjcGlfVXNl ck5vdGlmeSgiSFAiLCBzYy0+aGFuZGxlLAorCQkJYWNwaV9Vc2VyTm90aWZ5KCJIUCIsIEFD UElfUk9PVF9PQkpFQ1QsCiAJCQkgICAgMHhlMCtzYy0+d2FzX3d3YW5fb25fYWlyKTsKIAkJ fQogCX0KIH0KIAorc3RhdGljIHZvaWQKK2FjcGlfaHBfaWRlbnRpZnkoZHJpdmVyX3QgKmRy aXZlciwgZGV2aWNlX3QgcGFyZW50KQoreworCisJLyogRG9uJ3QgZG8gYW55dGhpbmcgaWYg ZHJpdmVyIGlzIGRpc2FibGVkLiAqLworCWlmIChhY3BpX2Rpc2FibGVkKCJocCIpKQorCQly ZXR1cm47CisKKwkvKiBBZGQgb25seSBhIHNpbmdsZSBkZXZpY2UgaW5zdGFuY2UuICovCisJ aWYgKGRldmljZV9maW5kX2NoaWxkKHBhcmVudCwgImFjcGlfaHAiLCAtMSkgIT0gTlVMTCkK KwkJcmV0dXJuOworCisJLyogTWFrZSBzdXJlIGFjcGlfd21pIGRyaXZlciBpcyBwcmVzZW50 LiAqLworCWlmIChkZXZjbGFzc19maW5kKCJhY3BpX3dtaSIpID09IE5VTEwpCisJCXJldHVy bjsKKworCS8qCisJICogQWRkIG91ciBkZXZpY2Ugd2l0aCBsYXRlIG9yZGVyLCBzbyB0aGF0 IGl0IGlzIGhvcGVmdWxseQorCSAqIHByb2JlZCBhZnRlciBhY3BpX3dtaS4KKwkgKiBYWFgg VXNlciBwcm9wZXIgY29uc3RhbnQgaW5zdGVhZCBvZiBVQ0hBUl9NQVggZm9yIG9yZGVyLgor CSAqLworCWlmIChCVVNfQUREX0NISUxEKHBhcmVudCwgVUNIQVJfTUFYLCAiYWNwaV9ocCIs IC0xKSA9PSBOVUxMKQorCQlkZXZpY2VfcHJpbnRmKHBhcmVudCwgImFkZCBhY3BpX2hwIGNo aWxkIGZhaWxlZFxuIik7Cit9CisKIHN0YXRpYyBpbnQKIGFjcGlfaHBfcHJvYmUoZGV2aWNl X3QgZGV2KQogewotCWlmIChhY3BpX2Rpc2FibGVkKCJocCIpIHx8IGRldmljZV9nZXRfdW5p dChkZXYpICE9IDApCisKKwkvKiBTa2lwIGF1dG8tZW51bWVyYXRlZCBkZXZpY2VzIGZyb20g QUNQSSBuYW1lc3BhY2UuICovCisJaWYgKGFjcGlfZ2V0X2hhbmRsZShkZXYpICE9IE5VTEwp CiAJCXJldHVybiAoRU5YSU8pOwogCWRldmljZV9zZXRfZGVzYyhkZXYsICJIUCBBQ1BJLVdN SSBNYXBwaW5nIik7CiAKQEAgLTQ2MCw3ICs0ODksNiBAQCBhY3BpX2hwX2F0dGFjaChkZXZp Y2VfdCBkZXYpCiAKIAlzYyA9IGRldmljZV9nZXRfc29mdGMoZGV2KTsKIAlzYy0+ZGV2ID0g ZGV2OwotCXNjLT5oYW5kbGUgPSBhY3BpX2dldF9oYW5kbGUoZGV2KTsKIAlzYy0+aGFzX25v dGlmeSA9IDA7CiAJc2MtPmhhc19jbWkgPSAwOwogCXNjLT5ibHVldG9vdGhfZW5hYmxlX2lm X3JhZGlvX29uID0gMDsKQEAgLTQ3Nyw3ICs1MDUsNyBAQCBhY3BpX2hwX2F0dGFjaChkZXZp Y2VfdCBkZXYpCiAJc2MtPnZlcmJvc2UgPSAwOwogCW1lbXNldChzYy0+Y21pX29yZGVyLCAw LCBzaXplb2Yoc2MtPmNtaV9vcmRlcikpOwogCi0JaWYgKCEod21pX2RldmNsYXNzID0gZGV2 Y2xhc3NfZmluZCAoImFjcGlfd21pIikpKSB7CisJaWYgKCEod21pX2RldmNsYXNzID0gZGV2 Y2xhc3NfZmluZCgiYWNwaV93bWkiKSkpIHsKIAkJZGV2aWNlX3ByaW50ZihkZXYsICJDb3Vs ZG4ndCBmaW5kIGFjcGlfd21pIGRldmNsYXNzXG4iKTsKIAkJcmV0dXJuIChFSU5WQUwpOwog CX0K --------------080100030005090509050807--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009030800.o8380LcZ052280>