Date: Fri, 5 Sep 2014 18:27:14 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Matthias Andree <matthias.andree@gmx.de> Cc: freebsd-ports@freebsd.org Subject: Re: First step (Re: [BRAINSTORMING] simplifying maintainer's life) Message-ID: <20140905162714.GB40535@ivaldir.etoilebsd.net> In-Reply-To: <5409E30A.7010808@gmx.de> References: <20140903082538.GE63085@ivaldir.etoilebsd.net> <20140905081911.GB25840@ivaldir.etoilebsd.net> <5409E30A.7010808@gmx.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--oC1+HKm2/end4ao3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Sep 05, 2014 at 06:21:30PM +0200, Matthias Andree wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>=20
> Am 05.09.2014 um 10:19 schrieb Baptiste Daroussin:
> > After the discussion that happened here is what I think we should do
> > If no stong objections are raised thise this will happen in pkg 1.3.8
> >=20
> > - Ignore mtree in packages
> > - Automatically handle directory removal for any directory under PREFIX
> > - Introduce @dir (in fact already there) for directories with special c=
are:
> > * empty directories
> > * directories with special credential (@dir(user,group,mode))
> > - Consider directories out of PREFIX as special hence needing to be lis=
ted with
> > @dir
> >=20
> > @dirrmtry and @dirrm will be considered changed into aliases for @dir b=
ut remain
> > for compatibility (with a warning if DEVELOPER_MODE is set)
>=20
> Is pkg now ready to reference-count multiple packages referencing the
> same directory?
It has always been :)
>=20
> >=20
> > - the possibility to accept regular plist entry as directories will be =
in but
> > disable by default, allowing vendors to rely on it if they do want bu=
t leaving
> > the ports tree not accepting them (that clarifies a lot what the the =
plist for
> > maintainers)
>=20
> I strongly object to this part, and request that such dead code not be
> added to pkg. This is a gratuitious change, for "vendors" that as of
> now are phantoms (lack a particular use case), and, as written before,
> it voids error checking on the file type, and dead code is usually
> buggier than used code because noone sees the bugs until the code is
> enabled (but not properly reintegrated) years later.
This is not dead code as I know already 2 vendors that uses that already,
secondly pkg(8) is used by system not using the ports tree, some of those
requires that feature.
In anycase there is no plan at all to activate this in the ports tree.
>=20
> The use case why we need the distinction is the common error
> if a maintainer forgets the mkdir in the {pre,do,post}-install: target,
> and the install path lacks the trailing slash, then packaging will no
> longer fail.
>=20
> Example:
>=20
> post-install:
> ${INSTALL_DATA} blah/something ${STAGEDIR}${DOCSDIR}/blah
>=20
> This will rename something to blah while installing into ${DOCSDIR},
> rather than installing "something" into ${DOCSDIR}/blah/.
>=20
> Especially with make makeplist or auto-plist rigs, this is bound to
> fail, and sit undiscovered for a while.
>=20
> If the distinction between directory and other file types remains
> explicit and mandatory, these errors are much harder to find.
>=20
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
>=20
> iEYEARECAAYFAlQJ4wIACgkQvmGDOQUufZU+ZwCggmcsS2yyo761R8X3a9xUHnm7
> /yYAn0L3wvhqQYR21uTedLTco3sAXxvt
> =3DNJdy
> -----END PGP SIGNATURE-----
regards,
Bapt
--oC1+HKm2/end4ao3
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlQJ5GIACgkQ8kTtMUmk6ExxpQCfVGn0nzugiGVZinMqDZXtbEPm
wwwAoJtUaZcFBaohgxq/HneF01OGqW9I
=aW2v
-----END PGP SIGNATURE-----
--oC1+HKm2/end4ao3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140905162714.GB40535>