Date: Tue, 20 May 2008 19:40:55 -0400 From: John Baldwin <jhb@freebsd.org> To: "David E. O'Brien" <obrien@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/gnu/usr.bin/gdb/kgdb trgt_mips.c Message-ID: <200805201940.56151.jhb@freebsd.org> In-Reply-To: <200805202254.m4KMsgoO088002@repoman.freebsd.org> References: <200805202254.m4KMsgoO088002@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 20 May 2008 06:54:42 pm David E. O'Brien wrote: > obrien 2008-05-20 22:54:42 UTC > > FreeBSD src repository > > Added files: > gnu/usr.bin/gdb/kgdb trgt_mips.c > Log: > MIPS arch target kgdb(1) support. > > Obtained from: Juniper Networks. Check for recent changes in the other MD backends. Things I noticed: - You should use ptid_get_pid() rather than ptid_get_tid() in kgdb_trgt_fetch_registers() (this is part of the changes to allow the 'tid' command to work over remote gdb). - You are missing a 'kgdb_trgt_new_objfile()' stub. The latter, at least, should have resulted in a link error. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200805201940.56151.jhb>