Date: Fri, 25 Jul 1997 23:50:53 +1000 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, smp@csn.net Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, fsmp@FreeBSD.ORG Subject: Re: cvs commit: src/sys/sys lock.h src/sys/i386/include param.h smp.h src/sys/i386/isa apic_ipl.s apic_vector.s ipl.s src/sys/i386/i386 exception.s mp_machdep.c mpapic.c Message-ID: <199707251350.XAA06472@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> > Modified files: >> > sys/i386/include param.h smp.h >> > Log: >> > Forced 32bit alignment of struct simple_lock in param.h. >> >> Alignment of the machine-dependent struct was already guaranteed, since >> the struct contains an int, and 32-bit alignment of ints is guaranteed >> in practice (although the CPU does not require it) since misalignment >> would be inefficient. > >this I disagree with. I think of it as a comment, forcing the observer >to actually think about how the variable is to be used. I wouldn't mind, except __attribute__(()) only works with gcc. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199707251350.XAA06472>