Date: Wed, 12 Feb 2003 14:13:46 +1100 (EST) From: Gregory Bond <gnb@itga.com.au> To: FreeBSD-gnats-submit@FreeBSD.org Cc: mchopra@engmail.uwaterloo.ca Subject: ports/48196: audio/abcde minor nits Message-ID: <200302120313.h1C3Djor045253@hellcat.itga.com.au>
next in thread | raw e-mail | index | archive | help
>Number: 48196
>Category: ports
>Synopsis: audio/abcde minor nits
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Feb 11 19:20:02 PST 2003
>Closed-Date:
>Last-Modified:
>Originator: Gregory Bond
>Release: FreeBSD 4.7-STABLE i386
>Organization:
ITG Australia Limited
>Environment:
System: FreeBSD hellcat.itga.com.au 4.7-STABLE FreeBSD 4.7-STABLE #15: Wed Jan 29 17:36:44 EST 2003 toor@grollo.itga.com.au:/usr/obj/usr/src/sys/HELLCAT i386
>Description:
The abcde port has a couple of minor problems:
1) The -x option (for "eject cd at the end") relies on the sysutils/eject port
being installed, but that is not listed in the dependencies.
2) Even if eject is installed, the script doesn't eject (eject
prints "no such file or directory") due to a clash over the use of the EJECT
environment variable between eject and abcd. The attached patch fixes that.
3) The abcde.conf file is set up to use dagrab, even if that isn't defined
when the port is built. I don't know enough about port hacking to work out
how to patch the default config based on whether makefile variables
are defined, so I can't offer a fix for this.
>How-To-Repeat:
cd /usr/ports/audio/abcde && make install
(note eject is not built)
abcde -x
(note eject fails)
cd /usr/ports/sysutils/eject && make install
abcde -x
....
eject: no such file or directory
>Fix:
The following patch fixed #1:
Index: Makefile
===================================================================
RCS file: /usr/ncvs/ports/audio/abcde/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile 11 Jan 2003 23:44:11 -0000 1.5
+++ Makefile 12 Feb 2003 03:11:20 -0000
@@ -17,7 +17,8 @@
RUN_DEPENDS= cd-discid:${PORTSDIR}/audio/cd-discid \
cdparanoia:${PORTSDIR}/audio/cdparanoia \
id3v2:${PORTSDIR}/audio/id3v2 \
- oggenc:${PORTSDIR}/audio/vorbis-tools
+ oggenc:${PORTSDIR}/audio/vorbis-tools \
+ eject:${PORTSDIR}/sysutils/eject
NO_BUILD= yes
WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
Add the following patchfile to the port to fix #2:
--- patch-eject begins here ---
--- abcde.orig Tue Feb 11 16:39:41 2003
+++ abcde Wed Feb 12 13:54:33 2003
@@ -1190,7 +1190,13 @@
# We are now finished with the cdrom - it can be safely ejected. Note that
# abcde will not have completed yet.
if [ "$EJECTCD" = "y" ]; then
- $EJECT $EJECTOPTS $CDROM
+ # FreeBSD eject uses the EJECT environment variable to name the CDROM
+ # but in this script EJECT is in the envionment and names the program
+ eject=$EJECT
+ unset EJECT
+ # The FreeBSD eject needs "adc0" not "/dev/adc0c"
+ cd="$(echo $CDROM | sed -e 's=.*/==;s=[a-h]$==;')"
+ $eject $EJECTOPTS $cd
fi
) | (
# Do the encoding, including parallelization of remote encoding
--- patch-eject ends here ---
No solution to #3 tho.
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200302120313.h1C3Djor045253>